Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 1957113002: Add comment to unit test for renderToAssociatedSink constraint (Closed)

Created:
4 years, 7 months ago by Guido Urdaneta
Modified:
4 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add comment with description explaining why we are not expecting the originally intended default value in unit test. BUG=604523 Committed: https://crrev.com/6c62c8c4653f26933ef53ab1cac404a5db453679 Cr-Commit-Position: refs/heads/master@{#392290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/renderer/media/user_media_client_impl_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957113002/1
4 years, 7 months ago (2016-05-08 12:19:19 UTC) #4
Guido Urdaneta
4 years, 7 months ago (2016-05-08 12:19:53 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-08 13:09:13 UTC) #7
tommi (sloooow) - chröme
lgtm
4 years, 7 months ago (2016-05-09 07:50:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957113002/1
4 years, 7 months ago (2016-05-09 08:26:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 08:30:28 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 08:31:57 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c62c8c4653f26933ef53ab1cac404a5db453679
Cr-Commit-Position: refs/heads/master@{#392290}

Powered by Google App Engine
This is Rietveld 408576698