Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2466)

Unified Diff: content/renderer/media/user_media_client_impl_unittest.cc

Issue 1957113002: Add comment to unit test for renderToAssociatedSink constraint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/user_media_client_impl_unittest.cc
diff --git a/content/renderer/media/user_media_client_impl_unittest.cc b/content/renderer/media/user_media_client_impl_unittest.cc
index e89bb3860627fbf9c3130eea29653e1e585fb1d3..749b9866558a3d6cfd4dfdbb07d00bec2834c704 100644
--- a/content/renderer/media/user_media_client_impl_unittest.cc
+++ b/content/renderer/media/user_media_client_impl_unittest.cc
@@ -624,6 +624,9 @@ TEST_F(UserMediaClientImplTest, RenderToAssociatedSinkConstraint) {
used_media_impl_->DeleteRequest(ms_dispatcher_->audio_input_request_id());
// If audio is requested, but no constraint, it should be true.
+ // Currently we expect it to be false due to a suspected bug in the
+ // device-matching code causing issues with some sound adapters.
+ // See crbug.com/604523
MockConstraintFactory factory;
blink::WebMediaConstraints audio_constraints =
factory.CreateWebMediaConstraints();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698