Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1956943002: [Part 5 of 6] Move TaskManagerTester to the task_management directory. (Closed)

Created:
4 years, 7 months ago by ncarter (slow)
Modified:
4 years, 7 months ago
Reviewers:
afakhry
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@tm_file_split4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move TaskManagerTester to the task_management directory. [splitting apart task_manager_browsertest_util, part 5 of 6] BUG=606963 Committed: https://crrev.com/22bcc7727da7c2134dfa1a902c1f0080c145ad3e Cr-Commit-Position: refs/heads/master@{#392662}

Patch Set 1 #

Patch Set 2 : Re-upload with similarity=5 #

Total comments: 4

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -552 lines) Patch
A + chrome/browser/task_management/task_manager_tester.h View 1 2 chunks +17 lines, -73 lines 0 comments Download
A + chrome/browser/task_management/task_manager_tester.cc View 1 2 2 chunks +9 lines, -253 lines 0 comments Download
M chrome/browser/task_manager/legacy_task_manager_tester.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/legacy_task_manager_tester.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 2 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest_util.h View 2 chunks +0 lines, -36 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest_util.cc View 1 2 5 chunks +4 lines, -172 lines 0 comments Download
M chrome/browser/ui/task_manager/task_manager_table_model.h View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
ncarter (slow)
Ahmed, please review (this is part 5)
4 years, 7 months ago (2016-05-06 22:29:07 UTC) #3
afakhry
https://codereview.chromium.org/1956943002/diff/20001/chrome/browser/task_manager/legacy_task_manager_tester.h File chrome/browser/task_manager/legacy_task_manager_tester.h (right): https://codereview.chromium.org/1956943002/diff/20001/chrome/browser/task_manager/legacy_task_manager_tester.h#newcode16 chrome/browser/task_manager/legacy_task_manager_tester.h:16: class LegacyTaskManagerTester : public task_management::TaskManagerTester { I'll have to ...
4 years, 7 months ago (2016-05-07 00:23:59 UTC) #4
ncarter (slow)
https://codereview.chromium.org/1956943002/diff/20001/chrome/browser/task_manager/legacy_task_manager_tester.h File chrome/browser/task_manager/legacy_task_manager_tester.h (right): https://codereview.chromium.org/1956943002/diff/20001/chrome/browser/task_manager/legacy_task_manager_tester.h#newcode16 chrome/browser/task_manager/legacy_task_manager_tester.h:16: class LegacyTaskManagerTester : public task_management::TaskManagerTester { On 2016/05/07 00:23:59, ...
4 years, 7 months ago (2016-05-07 22:23:09 UTC) #5
ncarter (slow)
https://codereview.chromium.org/1956943002/diff/20001/chrome/browser/task_manager/task_manager_browsertest_util.cc File chrome/browser/task_manager/task_manager_browsertest_util.cc (right): https://codereview.chromium.org/1956943002/diff/20001/chrome/browser/task_manager/task_manager_browsertest_util.cc#newcode49 chrome/browser/task_manager/task_manager_browsertest_util.cc:49: &ResourceChangeObserver::OnResourceChange, base::Unretained(this))); On 2016/05/07 00:23:59, afakhry wrote: > mmm, ...
4 years, 7 months ago (2016-05-09 20:26:35 UTC) #6
afakhry
lgtm
4 years, 7 months ago (2016-05-09 20:28:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956943002/40001
4 years, 7 months ago (2016-05-10 18:38:48 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-10 18:43:52 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 18:45:07 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/22bcc7727da7c2134dfa1a902c1f0080c145ad3e
Cr-Commit-Position: refs/heads/master@{#392662}

Powered by Google App Engine
This is Rietveld 408576698