Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5417)

Unified Diff: chrome/browser/task_manager/task_manager_browsertest_util.h

Issue 1956943002: [Part 5 of 6] Move TaskManagerTester to the task_management directory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tm_file_split4
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/task_manager_browsertest_util.h
diff --git a/chrome/browser/task_manager/task_manager_browsertest_util.h b/chrome/browser/task_manager/task_manager_browsertest_util.h
index 2bf3a9dc4cc73dc718a39731ddb97fd5d503fe6a..19d4e5ffc21a83aa38bd34b1ee3765f950e84f7b 100644
--- a/chrome/browser/task_manager/task_manager_browsertest_util.h
+++ b/chrome/browser/task_manager/task_manager_browsertest_util.h
@@ -7,14 +7,8 @@
#include <stddef.h>
-#include <memory>
-
#include "base/strings/string16.h"
-namespace content {
-class WebContents;
-}
-
// TODO(nick): Move everything here into the task_management namespace.
namespace task_manager {
namespace browsertest_util {
@@ -29,36 +23,6 @@ enum class ColumnSpecifier {
COLUMN_NONE, // Default value.
};
-// An adapter that abstracts away the difference of old vs. new task manager.
-class TaskManagerTester {
- public:
- virtual ~TaskManagerTester() {}
-
- // Get the number of rows currently in the task manager.
- virtual int GetRowCount() = 0;
-
- // Get the title text of a particular |row|.
- virtual base::string16 GetRowTitle(int row) = 0;
-
- // Hide or show a column. If a column is not visible its stats are not
- // necessarily gathered.
- virtual void ToggleColumnVisibility(ColumnSpecifier column) = 0;
-
- // Get the value of a column as an int64. Memory values are in bytes.
- virtual int64_t GetColumnValue(ColumnSpecifier column, int row) = 0;
-
- // If |row| is associated with a WebContents, return its SessionID. Otherwise,
- // return -1.
- virtual int32_t GetTabId(int row) = 0;
-
- // Kill the process of |row|.
- virtual void Kill(int row) = 0;
-};
-
-// Creates a TaskManagerTester backed by the current task manager. The task
-// manager should already be visible when you call this function.
-std::unique_ptr<TaskManagerTester> GetTaskManagerTester();
-
// Runs the message loop, observing the task manager, until there are exactly
// |resource_count| many resources whose titles match the pattern
// |title_pattern|. The match is done via string_util's base::MatchPattern, so
« no previous file with comments | « chrome/browser/task_manager/task_manager_browsertest.cc ('k') | chrome/browser/task_manager/task_manager_browsertest_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698