Do not materialize context-allocated values for debug-evaluate.

Do not materialize context-allocated values for debug-evaluate.

BUG=259300
R=ulan@chromium.org, verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15727

[Yang, 2013-07-17 12:06:40]

Ulan, please take a second look at the change in scope.cc.
Toon, please review the rest.

[ulan, 2013-07-17 12:12:45]

Changes in scope.cc LGTM

[Toon Verwaest, 2013-07-17 14:55:04]

lgtm with 1 comment and 2 for future reference.

https://codereview.chromium.org/19569003/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/19569003/diff/1/src/runtime.cc#newcode11184
src/runtime.cc:11184: Isolate* isolate,
This still isn't strictly correct, because we can get access to the ScopeObject
and do weird stuff like Object.defineProperty:

o = {x:1};
with(o) {
  x=function(){return this;};
  a=x();
  Object.defineProperty(a, "z", {get:function(){return 10;}})
}
o.z --> 10

But I guess we can keep it as is for now.

https://codereview.chromium.org/19569003/diff/1/src/runtime.cc#newcode11232
src/runtime.cc:11232: // Optimized frames are not supported.
I'd prefer if this were an ASSERT. If we can't do it yet, at least add a TODO.

https://codereview.chromium.org/19569003/diff/1/src/runtime.cc#newcode12484
src/runtime.cc:12484: return target;
This does not work in general for aliasing non-strict argument objects. But ok,
lets leave it like this for now.

[Yang, 2013-07-17 15:29:07]

Committed patchset #2 manually as r15727 (presubmit successful).