Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: src/mirror-debugger.js

Issue 19569003: Do not materialize context-allocated values for debug-evaluate. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: improved test Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/runtime.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/mirror-debugger.js
diff --git a/src/mirror-debugger.js b/src/mirror-debugger.js
index 28b8fc81baa2c067022dfeb67c03303ee3767c29..28ef24de0f2b9c372c9231726bcf295df87aae2a 100644
--- a/src/mirror-debugger.js
+++ b/src/mirror-debugger.js
@@ -1699,30 +1699,12 @@ FrameMirror.prototype.stepInPositions = function() {
FrameMirror.prototype.evaluate = function(source, disable_break,
opt_context_object) {
- var result_array = %DebugEvaluate(this.break_id_,
- this.details_.frameId(),
- this.details_.inlinedFrameIndex(),
- source,
- Boolean(disable_break),
- opt_context_object);
- // Silently ignore local variables changes if the frame is optimized.
- if (!this.isOptimizedFrame()) {
- var local_scope_on_stack = result_array[1];
- var local_scope_modifed = result_array[2];
- for (var n in local_scope_modifed) {
- var value_on_stack = local_scope_on_stack[n];
- var value_modifed = local_scope_modifed[n];
- if (value_on_stack !== value_modifed) {
- %SetScopeVariableValue(this.break_id_,
- this.details_.frameId(),
- this.details_.inlinedFrameIndex(),
- 0,
- n,
- value_modifed);
- }
- }
- }
- return MakeMirror(result_array[0]);
+ return MakeMirror(%DebugEvaluate(this.break_id_,
+ this.details_.frameId(),
+ this.details_.inlinedFrameIndex(),
+ source,
+ Boolean(disable_break),
+ opt_context_object));
};
« no previous file with comments | « no previous file | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698