Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1956893004: Don't send extension info for non-webstore extensions during update check (Closed)

Created:
4 years, 7 months ago by gayane -on leave until 09-2017
Modified:
4 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't send extension info for non-webstore extensions during update check BUG=609960 Committed: https://crrev.com/76fe98a8f83d1d815fc0dfc3cd144a96f8d5f9ef Cr-Commit-Position: refs/heads/master@{#392185}

Patch Set 1 : #

Patch Set 2 : fix unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -69 lines) Patch
M chrome/browser/extensions/updater/chrome_extension_downloader_factory.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 4 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_accessor.h View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/browser/updater/extension_downloader.h View 2 chunks +0 lines, -8 lines 0 comments Download
M extensions/browser/updater/extension_downloader.cc View 2 chunks +34 lines, -46 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
gayane -on leave until 09-2017
Please have a look
4 years, 7 months ago (2016-05-06 20:48:37 UTC) #3
Alexei Svitkine (slow)
LGTM! Woot!
4 years, 7 months ago (2016-05-06 20:51:51 UTC) #4
asargent_no_longer_on_chrome
lgtm
4 years, 7 months ago (2016-05-06 21:40:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956893004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956893004/40001
4 years, 7 months ago (2016-05-06 21:46:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-06 22:38:52 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 22:40:08 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/76fe98a8f83d1d815fc0dfc3cd144a96f8d5f9ef
Cr-Commit-Position: refs/heads/master@{#392185}

Powered by Google App Engine
This is Rietveld 408576698