Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: chrome/browser/extensions/updater/extension_updater_unittest.cc

Issue 1956893004: Don't send extension info for non-webstore extensions during update check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix unittests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/updater/extension_updater_unittest.cc
diff --git a/chrome/browser/extensions/updater/extension_updater_unittest.cc b/chrome/browser/extensions/updater/extension_updater_unittest.cc
index b24e06e9a332b55508e3a619b3a69af79889552a..d4b5c81c96a5813919d1badbe89e92eb36bd4c46 100644
--- a/chrome/browser/extensions/updater/extension_updater_unittest.cc
+++ b/chrome/browser/extensions/updater/extension_updater_unittest.cc
@@ -302,8 +302,7 @@ class MockService : public TestExtensionService {
explicit MockService(TestExtensionPrefs* prefs)
: prefs_(prefs),
pending_extension_manager_(&profile_),
- downloader_delegate_override_(NULL),
- enable_metrics_(false) {}
+ downloader_delegate_override_(NULL) {}
~MockService() override {}
@@ -327,10 +326,6 @@ class MockService : public TestExtensionService {
return fake_token_service_.get();
}
- // Controls whether metrics (enable/disabled state, etc.) are sent in the
- // autoupdate ping requests.
- void set_enable_metrics(bool enable) { enable_metrics_ = enable; }
-
// Creates test extensions and inserts them into list. The name and
// version are all based on their index. If |update_url| is non-null, it
// will be used as the update_url for each extension.
@@ -381,8 +376,6 @@ class MockService : public TestExtensionService {
request_context(), downloader_delegate_override_
? downloader_delegate_override_
: delegate);
- if (enable_metrics_)
- downloader->set_enable_extra_update_metrics(true);
return downloader;
}
@@ -405,8 +398,6 @@ class MockService : public TestExtensionService {
ExtensionDownloaderDelegate* downloader_delegate_override_;
- bool enable_metrics_;
-
DISALLOW_COPY_AND_ASSIGN(MockService);
};

Powered by Google App Engine
This is Rietveld 408576698