Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1956753002: SkAdvancedTypefaceMetrics: fail cleanly. (Closed)

Created:
4 years, 7 months ago by hal.canary
Modified:
4 years, 7 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/core/SkAdvancedTypefaceMetrics.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956753002/1
4 years, 7 months ago (2016-05-06 14:55:01 UTC) #3
hal.canary
PTAL
4 years, 7 months ago (2016-05-06 14:55:06 UTC) #5
tomhudson
LGTM only because you pinky-swore that all the callers would be happy with null.
4 years, 7 months ago (2016-05-06 15:07:51 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-06 15:16:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956753002/1
4 years, 7 months ago (2016-05-06 15:44:52 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 15:45:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bad1abc748a4a7cd4863803e1c90ac0769a98d0a

Powered by Google App Engine
This is Rietveld 408576698