src/core/SkAdvancedTypefaceMetrics.cpp - Issue 1956753002: SkAdvancedTypefaceMetrics: fail cleanly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkAdvancedTypefaceMetrics.cpp

Issue 1956753002: SkAdvancedTypefaceMetrics: fail cleanly. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkAdvancedTypefaceMetrics.cpp

diff --git a/src/core/SkAdvancedTypefaceMetrics.cpp b/src/core/SkAdvancedTypefaceMetrics.cpp

index 318f4a06bc23cbbb4801a76ea55b7f156360db75..0e9ba95bf40896f123458a44331ef174529a4022 100644

--- a/src/core/SkAdvancedTypefaceMetrics.cpp

+++ b/src/core/SkAdvancedTypefaceMetrics.cpp

@@ -257,6 +257,9 @@ SkAdvancedTypefaceMetrics::AdvanceMetric<Data>* getAdvanceData(

}

if (curRange->fStartId == lastIndex) {

SkASSERT(prevRange);

+ if (!prevRange) {

+ return nullptr; // https://crbug.com/567031

+ }

SkASSERT(prevRange->fNext->fStartId == lastIndex);

prevRange->fNext.reset();

} else {

« no previous file with comments | « no previous file | no next file » | no next file with comments »