Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1956693002: [compiler] Pass inlining_id via relocation info. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Pass inlining_id via relocation info. This passes the inlining_id of deoptimization points via the relocation info instead of via a side-channel to the CPU profiler. This is one step towards deprecating the side-channel in question and avoid the need for performing a lookup of the return address of the deopt point. R=jarin@chromium.org Committed: https://crrev.com/32049620d26ef0dbab68062841a93f77e56efdd3 Cr-Commit-Position: refs/heads/master@{#36177}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -81 lines) Patch
M src/arm/assembler-arm.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/assembler-arm64.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/assembler-arm64.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/assembler.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/assembler.cc View 5 chunks +10 lines, -4 lines 0 comments Download
M src/compiler.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/crankshaft/lithium-codegen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/lithium-codegen.cc View 2 chunks +5 lines, -11 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/deoptimizer.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download
M src/disassembler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips/assembler-mips.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/assembler-ppc.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/profiler/cpu-profiler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/profiler/cpu-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/profiler/cpu-profiler-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/profiler/profile-generator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/profiler/profile-generator.cc View 1 chunk +1 line, -9 lines 0 comments Download
M src/s390/assembler-s390.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x87/assembler-x87.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-06 12:17:14 UTC) #1
Jarin
lgtm. I like it.
4 years, 7 months ago (2016-05-11 13:19:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956693002/20001
4 years, 7 months ago (2016-05-11 13:56:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 14:05:48 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 14:06:44 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/32049620d26ef0dbab68062841a93f77e56efdd3
Cr-Commit-Position: refs/heads/master@{#36177}

Powered by Google App Engine
This is Rietveld 408576698