Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: src/crankshaft/lithium-codegen.cc

Issue 1956693002: [compiler] Pass inlining_id via relocation info. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/lithium-codegen.h ('k') | src/crankshaft/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/lithium-codegen.cc
diff --git a/src/crankshaft/lithium-codegen.cc b/src/crankshaft/lithium-codegen.cc
index 6c2479024ea028d13e81edb819c39a72876ce5ea..9c2c579f4413fe87985644a65c05f135e5d48f38 100644
--- a/src/crankshaft/lithium-codegen.cc
+++ b/src/crankshaft/lithium-codegen.cc
@@ -158,8 +158,9 @@ void LCodeGenBase::Comment(const char* format, ...) {
void LCodeGenBase::DeoptComment(const Deoptimizer::DeoptInfo& deopt_info) {
SourcePosition position = deopt_info.position;
+ int inlining_id = deopt_info.inlining_id;
int raw_position = position.IsUnknown() ? 0 : position.raw();
- masm()->RecordDeoptReason(deopt_info.deopt_reason, raw_position);
+ masm()->RecordDeoptReason(deopt_info.deopt_reason, raw_position, inlining_id);
}
@@ -364,19 +365,12 @@ void LCodeGenBase::PopulateDeoptimizationLiteralsWithInlinedFunctions() {
}
}
-void LCodeGenBase::LogDeoptCallPosition(int pc_offset, int inlining_id) {
- if (!info()->is_tracking_positions() || info()->IsStub()) return;
- auto& inlined_function_infos = info()->inlined_function_infos();
- DCHECK_LT(static_cast<size_t>(inlining_id), inlined_function_infos.size());
- inlined_function_infos.at(inlining_id).deopt_pc_offsets.push_back(pc_offset);
-}
-
Deoptimizer::DeoptInfo LCodeGenBase::MakeDeoptInfo(
LInstruction* instr, Deoptimizer::DeoptReason deopt_reason) {
- Deoptimizer::DeoptInfo deopt_info(instr->hydrogen_value()->position(),
- deopt_reason);
HEnterInlined* enter_inlined = instr->environment()->entry();
- deopt_info.inlining_id = enter_inlined ? enter_inlined->inlining_id() : 0;
+ int inlining_id = enter_inlined ? enter_inlined->inlining_id() : 0;
+ Deoptimizer::DeoptInfo deopt_info(instr->hydrogen_value()->position(),
+ deopt_reason, inlining_id);
return deopt_info;
}
} // namespace internal
« no previous file with comments | « src/crankshaft/lithium-codegen.h ('k') | src/crankshaft/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698