Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3561)

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 1956633002: Menu hook plumbed through to RequestCoordinator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback per FGorski && DougArnett Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_bridge.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc
index 830d91d2e2a1fac8303818a9c504ecb89f7ea034..a25d725cd966f4238c31b2d9621d6eb65c771267 100644
--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc
+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc
@@ -12,8 +12,11 @@
#include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h"
#include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
#include "chrome/browser/android/offline_pages/offline_page_utils.h"
+#include "chrome/browser/android/offline_pages/request_coordinator_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_android.h"
+#include "components/offline_pages/background/request_coordinator.h"
+#include "components/offline_pages/background/save_page_request.h"
#include "components/offline_pages/offline_page_feature.h"
#include "components/offline_pages/offline_page_item.h"
#include "components/offline_pages/offline_page_model.h"
@@ -316,6 +319,26 @@ void OfflinePageBridge::SavePage(
base::Bind(&SavePageCallback, j_callback_ref, url));
}
+void OfflinePageBridge::SavePageLater(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jstring>& j_url,
+ const JavaParamRef<jstring>& j_client_id_namespace,
+ const JavaParamRef<jstring>& j_client_id) {
+ offline_pages::ClientId client_id;
+ client_id.name_space = ConvertJavaStringToUTF8(env, j_client_id_namespace);
+ client_id.id = ConvertJavaStringToUTF8(env, j_client_id);
+
+ // Get a background request coordinator.
jianli 2016/05/06 20:39:04 nit: remove this comment and next comment since th
Pete Williamson 2016/05/06 21:30:28 Done.
+ RequestCoordinator* coordinator =
+ offline_pages::RequestCoordinatorFactory::GetInstance()->
+ GetForBrowserContext(browser_context_);
+
+ // Make a request to the background offliner.
+ coordinator->SavePageLater(
+ GURL(ConvertJavaStringToUTF8(env, j_url)), client_id);
+}
+
void OfflinePageBridge::DeletePages(
JNIEnv* env,
const JavaParamRef<jobject>& obj,

Powered by Google App Engine
This is Rietveld 408576698