Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java

Issue 1956633002: Menu hook plumbed through to RequestCoordinator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback per FGorski && DougArnett Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
index 2558559aa027d96eeedb0899dbaa01191f4fb512..3237f9932912f0843f13b6ca151627699a6772c2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
@@ -13,6 +13,8 @@ import org.chromium.chrome.browser.IntentHandler;
import org.chromium.chrome.browser.contextmenu.ContextMenuItemDelegate;
import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;
+import org.chromium.chrome.browser.offlinepages.ClientId;
+import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
import org.chromium.chrome.browser.tabmodel.document.TabDelegate;
@@ -23,6 +25,7 @@ import org.chromium.ui.base.Clipboard;
import org.chromium.ui.base.PageTransition;
import java.net.URI;
+import java.util.Date;
import java.util.Locale;
/**
@@ -164,6 +167,15 @@ public class TabContextMenuItemDelegate implements ContextMenuItemDelegate {
}
}
+ @Override
+ public void onSavePageLater(String linkUrl) {
+ OfflinePageBridge bridge = OfflinePageBridge.getForProfile(mTab.getProfile());
+ Date now = new Date();
+ long offline_id = now.getTime();
jianli 2016/05/06 20:39:04 I think it is a bit risky to use the time due to s
Pete Williamson 2016/05/06 21:30:28 Changed it to use Random. Again, this is just a t
jianli 2016/05/06 21:48:05 I think we probably need to give more careful thou
Pete Williamson 2016/05/06 23:56:27 Acknowledged. When we replace this test stub with
+ ClientId clientId = new ClientId("AsyncLoader", Long.toString(offline_id));
fgorski 2016/05/06 21:28:10 based on "bookmark" and "last_n" this should say "
Pete Williamson 2016/05/06 21:36:12 Done.
+ bridge.savePageLater(linkUrl, clientId);
+ }
+
/**
* Checks if spdy proxy is enabled for input url.
* @param url Input url to check for spdy setting.

Powered by Google App Engine
This is Rietveld 408576698