Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4875)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

Issue 1956633002: Menu hook plumbed through to RequestCoordinator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback per FGorski && DougArnett Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
index 061de4560fd764cf93c5245f45f62ea13ec08c79..d70a3821c6cdafd82c7d4e07c47da5fd1b578a0f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
@@ -414,6 +414,17 @@ public class OfflinePageBridge {
}
/**
+ * Save the given URL as an offline page when the network becomes available.
+ *
+ * @param url The given URL to save for later
+ * @param ClientId The client for the offline page, and the client's ID.
jianli 2016/05/06 20:39:03 nit: please update comment to Client ID for the
fgorski 2016/05/06 21:28:10 also it should say: clientId
Pete Williamson 2016/05/06 21:30:28 Done.
Pete Williamson 2016/05/06 21:36:12 Fixed it to say client ID before I saw your commen
+ */
+ public void savePageLater(final String url, final ClientId clientId) {
+ nativeSavePageLater(
+ mNativeOfflinePageBridge, url, clientId.getNamespace(), clientId.getId());
+ }
+
+ /**
* Deletes an offline page related to a specified bookmark.
*
* @param clientId Client ID for which the offline copy will be deleted.
@@ -621,6 +632,8 @@ public class OfflinePageBridge {
long nativeOfflinePageBridge, String offlineUrl);
private native void nativeSavePage(long nativeOfflinePageBridge, SavePageCallback callback,
WebContents webContents, String clientNamespace, String clientId);
+ private native void nativeSavePageLater(
+ long nativeOfflinePageBridge, String url, String clientNamespace, String clientId);
private native void nativeDeletePages(
long nativeOfflinePageBridge, DeletePageCallback callback, long[] offlineIds);
private native void nativeCheckMetadataConsistency(long nativeOfflinePageBridge);

Powered by Google App Engine
This is Rietveld 408576698