Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1956453004: Explicitly set checkbox state should not be influenced by defaultState (Closed)

Created:
4 years, 7 months ago by ramya.v
Modified:
4 years, 7 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly set checkbox state should not be influenced by defaultState BUG=608416 Committed: https://crrev.com/bf3ed6ce3fcda2745f9871a57d685c4cb7a1ea7c Cr-Commit-Position: refs/heads/master@{#392030}

Patch Set 1 #

Patch Set 2 : Added testcase #

Total comments: 2

Patch Set 3 : Updated as per review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-checked-state-affected-by-default-state.html View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
ramya.v
PTAL! Thanks
4 years, 7 months ago (2016-05-06 08:49:59 UTC) #2
tkent
https://codereview.chromium.org/1956453004/diff/20001/third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-checked-state-affected-by-default-state.html File third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-checked-state-affected-by-default-state.html (right): https://codereview.chromium.org/1956453004/diff/20001/third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-checked-state-affected-by-default-state.html#newcode3 third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-checked-state-affected-by-default-state.html:3: <script src="../../../resources/js-test.js"></script> Please use testharness.js instead of js-test.js for ...
4 years, 7 months ago (2016-05-06 08:51:37 UTC) #3
ramya.v
PTAL! Thanks https://codereview.chromium.org/1956453004/diff/20001/third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-checked-state-affected-by-default-state.html File third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-checked-state-affected-by-default-state.html (right): https://codereview.chromium.org/1956453004/diff/20001/third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-checked-state-affected-by-default-state.html#newcode3 third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-checked-state-affected-by-default-state.html:3: <script src="../../../resources/js-test.js"></script> On 2016/05/06 08:51:37, tkent wrote: ...
4 years, 7 months ago (2016-05-06 09:26:55 UTC) #4
tkent
lgtm
4 years, 7 months ago (2016-05-06 09:48:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956453004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956453004/40001
4 years, 7 months ago (2016-05-06 09:48:48 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-06 10:49:24 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 10:50:47 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/bf3ed6ce3fcda2745f9871a57d685c4cb7a1ea7c
Cr-Commit-Position: refs/heads/master@{#392030}

Powered by Google App Engine
This is Rietveld 408576698