third_party/WebKit/Source/core/html/HTMLInputElement.cpp - Issue 1956453004: Explicitly set checkbox state should not be influenced by defaultState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 1956453004: Explicitly set checkbox state should not be influenced by defaultState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated as per review comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-checked-state-affected-by-default-state.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

index 82dee5c3093090f07e209f6bcfafdb4c5f17249f..66964b1d31cb1258c171ee9951f0830ae097a3c1 100644

--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

@@ -899,10 +899,10 @@ bool HTMLInputElement::checked() const

void HTMLInputElement::setChecked(bool nowChecked, TextFieldEventBehavior eventBehavior)

{

+ m_reflectsCheckedAttribute = false;

if (checked() == nowChecked)

return;

- m_reflectsCheckedAttribute = false;

m_isChecked = nowChecked;

if (RadioButtonGroupScope* scope = radioButtonGroupScope())

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-checked-state-affected-by-default-state.html ('k') | no next file » | no next file with comments »