Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1956433003: LineBreaker doesn't need LayoutBlock(Flow) as a friend. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LineBreaker doesn't need LayoutBlock(Flow) as a friend. Committed: https://crrev.com/27419babbe5072d9d16630a79b3b1547b5e0bbd1 Cr-Commit-Position: refs/heads/master@{#392115}

Patch Set 1 #

Patch Set 2 : LayoutBlockFlow doesn't need to be a friend either #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
mstensho (USE GERRIT)
</3
4 years, 7 months ago (2016-05-06 12:44:05 UTC) #3
wkorman
lgtm
4 years, 7 months ago (2016-05-06 18:26:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956433003/20001
4 years, 7 months ago (2016-05-06 19:12:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-06 19:16:56 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 19:18:08 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/27419babbe5072d9d16630a79b3b1547b5e0bbd1
Cr-Commit-Position: refs/heads/master@{#392115}

Powered by Google App Engine
This is Rietveld 408576698