Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

Issue 1956433003: LineBreaker doesn't need LayoutBlock(Flow) as a friend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: LayoutBlockFlow doesn't need to be a friend either Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003-2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2003-2013 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * Copyright (C) 2013 Google Inc. All rights reserved. 7 * Copyright (C) 2013 Google Inc. All rights reserved.
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions are 10 * modification, are permitted provided that the following conditions are
(...skipping 564 matching lines...) Expand 10 before | Expand all | Expand 10 after
575 LayoutUnit m_paintInvalidationLogicalBottom; 575 LayoutUnit m_paintInvalidationLogicalBottom;
576 576
577 bool isSelfCollapsingBlock() const override; 577 bool isSelfCollapsingBlock() const override;
578 bool checkIfIsSelfCollapsingBlock() const; 578 bool checkIfIsSelfCollapsingBlock() const;
579 579
580 protected: 580 protected:
581 OwnPtr<LayoutBlockFlowRareData> m_rareData; 581 OwnPtr<LayoutBlockFlowRareData> m_rareData;
582 OwnPtr<FloatingObjects> m_floatingObjects; 582 OwnPtr<FloatingObjects> m_floatingObjects;
583 583
584 friend class MarginInfo; 584 friend class MarginInfo;
585 friend class LineBreaker;
586 friend class LineWidth; // needs to know FloatingObject 585 friend class LineWidth; // needs to know FloatingObject
587 586
588 // FIXME-BLOCKFLOW: These methods have implementations in 587 // FIXME-BLOCKFLOW: These methods have implementations in
589 // LayoutBlockFlowLine. They should be moved to the proper header once the 588 // LayoutBlockFlowLine. They should be moved to the proper header once the
590 // line layout code is separated from LayoutBlock and LayoutBlockFlow. 589 // line layout code is separated from LayoutBlock and LayoutBlockFlow.
591 // START METHODS DEFINED IN LayoutBlockFlowLine 590 // START METHODS DEFINED IN LayoutBlockFlowLine
592 private: 591 private:
593 InlineFlowBox* createLineBoxes(LineLayoutItem, const LineInfo&, InlineBox* c hildBox); 592 InlineFlowBox* createLineBoxes(LineLayoutItem, const LineInfo&, InlineBox* c hildBox);
594 RootInlineBox* constructLine(BidiRunList<BidiRun>&, const LineInfo&); 593 RootInlineBox* constructLine(BidiRunList<BidiRun>&, const LineInfo&);
595 void setMarginsForRubyRun(BidiRun*, LayoutRubyRun*, LayoutObject*, const Lin eInfo&); 594 void setMarginsForRubyRun(BidiRun*, LayoutRubyRun*, LayoutObject*, const Lin eInfo&);
(...skipping 25 matching lines...) Expand all
621 620
622 // END METHODS DEFINED IN LayoutBlockFlowLine 621 // END METHODS DEFINED IN LayoutBlockFlowLine
623 622
624 }; 623 };
625 624
626 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlockFlow, isLayoutBlockFlow()); 625 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlockFlow, isLayoutBlockFlow());
627 626
628 } // namespace blink 627 } // namespace blink
629 628
630 #endif // LayoutBlockFlow_h 629 #endif // LayoutBlockFlow_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698