Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: chrome/browser/android/logo_service.cc

Issue 1956393002: Add a feature flag for enabling transparent doodle request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@transparent-doodle
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/logo_service.cc
diff --git a/chrome/browser/android/logo_service.cc b/chrome/browser/android/logo_service.cc
index ff639514b5eaaccd4bbcef088bc59d9bbf192e91..50556b24b73e039091d56869351f74e813886ddd 100644
--- a/chrome/browser/android/logo_service.cc
+++ b/chrome/browser/android/logo_service.cc
@@ -4,9 +4,11 @@
#include "chrome/browser/android/logo_service.h"
+#include "base/feature_list.h"
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "base/thread_task_runner_handle.h"
+#include "chrome/browser/android/chrome_feature_list.h"
#include "chrome/browser/image_decoder.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/search_engines/template_url_service_factory.h"
@@ -125,7 +127,8 @@ void LogoService::GetLogo(search_provider_logos::LogoObserver* observer) {
GetGoogleDoodleURL(profile_),
base::Bind(&search_provider_logos::GoogleParseLogoResponse),
base::Bind(&search_provider_logos::GoogleAppendQueryparamsToLogoURL),
- true);
+ true,
tschumann 2016/05/10 08:44:34 a comment explaining the semantics of the bools wo
Marc Treib 2016/05/10 08:54:59 Haha, I just made the exact same comment on the ot
atanasova 2016/05/10 09:12:54 Done.
tschumann 2016/05/10 09:19:22 To follow up: In google3 there's a recent trend to
+ base::FeatureList::IsEnabled(chrome::android::kNTPSnippetsFeature));
logo_tracker_->GetLogo(observer);
}

Powered by Google App Engine
This is Rietveld 408576698