Add a feature flag for enabling transparent doodle request.

chrome/browser/android/logo_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/logo_service.h"
 
+#include "base/feature_list.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/thread_task_runner_handle.h"
+#include "chrome/browser/android/chrome_feature_list.h"
 #include "chrome/browser/image_decoder.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/browser/search_engines/ui_thread_search_terms_data.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "components/search_engines/template_url_service.h"
 #include "components/search_provider_logos/google_logo_api.h"
 #include "content/public/browser/browser_thread.h"
 #include "net/url_request/url_request_context_getter.h"
 
@@ skipping 98 matching lines @@
         BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE),
         BrowserThread::GetBlockingPool(), profile_->GetRequestContext(),
         std::unique_ptr<search_provider_logos::LogoDelegate>(
             new ChromeLogoDelegate())));
   }
 
   logo_tracker_->SetServerAPI(
       GetGoogleDoodleURL(profile_),
       base::Bind(&search_provider_logos::GoogleParseLogoResponse),
       base::Bind(&search_provider_logos::GoogleAppendQueryparamsToLogoURL),
-      true);
+      true,

[tschumann, 2016/05/10 08:44:34]

a comment explaining the semantics of the bools would be nice. Not sure what the
chrome way of doing this is; something like:
/*wants_cta=*/true,
or
true /* wants_cta */

would be nice.

[Marc Treib, 2016/05/10 08:54:59]

Haha, I just made the exact same comment on the other CL :D
I think the second way is more common in Chromiuem, but I've seen both. Either's
fine IMO.

[atanasova, 2016/05/10 09:12:54]

Done.

[tschumann, 2016/05/10 09:19:22]

To follow up: In google3 there's a recent trend to /*foo=*/bar, as we have a
supporting critique finding which will tell you if the comment is wrong -- i.e.
if the argument name is different.

+      base::FeatureList::IsEnabled(chrome::android::kNTPSnippetsFeature));
   logo_tracker_->GetLogo(observer);
 }
 
 // LogoServiceFactory ---------------------------------------------------------
 
 // static
 LogoService* LogoServiceFactory::GetForProfile(Profile* profile) {
   return static_cast<LogoService*>(
       GetInstance()->GetServiceForBrowserContext(profile, true));
 }
@@ skipping 10 matching lines @@
 }
 
 LogoServiceFactory::~LogoServiceFactory() {}
 
 KeyedService* LogoServiceFactory::BuildServiceInstanceFor(
     content::BrowserContext* context) const {
   Profile* profile = static_cast<Profile*>(context);
   DCHECK(!profile->IsOffTheRecord());
   return new LogoService(profile);
 }