Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Unified Diff: content/public/browser/navigation_handle.h

Issue 1956383003: Forwarding POST body into renderer after a cross-site transfer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: GoBackToCrossSitePostWithRedirect is fixed by this CL. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index 7f1e8ab7111b27370271d709a85602ea5242a041..a91f0018ad2770018828cc633c254d6525e7f6fa 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -89,9 +89,9 @@ class CONTENT_EXPORT NavigationHandle {
// This corresponds to NavigationThrottle::WillSendRequest. They should not
// be queried before that.
- // Whether the navigation is a POST or a GET. This may change during the
- // navigation when encountering a server redirect.
- virtual bool IsPost() = 0;
+ // HTTP method of the navigation (i.e. a POST or a GET). This may change
+ // during the navigation when encountering a server redirect.
+ virtual const std::string& GetMethod() = 0;
Łukasz Anforowicz 2016/06/01 16:28:38 Hmmm... does the IsPost -> GetMethod change still
Charlie Reis 2016/06/01 23:46:32 Heh. I think we just need to pick an approach and
Łukasz Anforowicz 2016/06/02 22:07:04 In this case, let me go back to NavigationHandle::
// Returns a sanitized version of the referrer for this request.
virtual const Referrer& GetReferrer() = 0;

Powered by Google App Engine
This is Rietveld 408576698