Forwarding POST body into renderer after a cross-site transfer.

content/common/navigation_params.cc

Index: content/common/navigation_params.cc
diff --git a/content/common/navigation_params.cc b/content/common/navigation_params.cc
index 39162ffe2bd06e52a2694616b60de3cf43042307..7a7ebf854c1218f66ac947d9a6ce303c26194471 100644
--- a/content/common/navigation_params.cc
+++ b/content/common/navigation_params.cc
@@ -62,7 +62,10 @@ CommonNavigationParams::CommonNavigationParams(
       lofi_state(lofi_state),
       navigation_start(navigation_start),
       method(method),
-      post_data(post_data) {}
+      post_data(post_data) {
+  // |method != "POST"| should imply absence of |post_data|.
+  DCHECK(method == "POST" || !post_data);

[Łukasz Anforowicz, 2016/06/01 16:28:38]

I guess we could also repeat the "assertion" from
NavigationControllerImpl::LoadURLWithParams which says something like
(pseudo-code): DCHECK_IMPLIES(method == "POST", url.SchemeIs(http or https)).

[Charlie Reis, 2016/06/01 23:46:32]

Sounds like a good idea.

[Łukasz Anforowicz, 2016/06/02 22:07:04]

I tried this in patchset 24, but it turns out that the new DCHECK failed for the
following case:
  url=chrome-extension://...
  method=POST
  body=1
The failure happened in navigator_impl.cc and in navigation_handle_impl.cc (but
I don't have at this point a specific repro for tickling this DCHECK in
navigation_params.cc).  Repro tests (browser_tests):
- InlineLoginUISafeIframeBrowserTest.ConfirmationRequiredForNonsecureSignin
- ExtensionWebRequestApiTest.PostData*

+}
 
 CommonNavigationParams::CommonNavigationParams(
     const CommonNavigationParams& other) = default;