Forwarding POST body into renderer after a cross-site transfer.

content/common/navigation_params.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/navigation_params.h"
 
 #include "build/build_config.h"
 #include "content/common/service_worker/service_worker_types.h"
 #include "content/public/common/browser_side_navigation_policy.h"
 #include "content/public/common/url_constants.h"
@@ skipping 44 matching lines @@
       navigation_type(navigation_type),
       allow_download(allow_download),
       should_replace_current_entry(should_replace_current_entry),
       ui_timestamp(ui_timestamp),
       report_type(report_type),
       base_url_for_data_url(base_url_for_data_url),
       history_url_for_data_url(history_url_for_data_url),
       lofi_state(lofi_state),
       navigation_start(navigation_start),
       method(method),
-      post_data(post_data) {}
+      post_data(post_data) {
+  // |method != "POST"| should imply absence of |post_data|.
+  DCHECK(method == "POST" || !post_data);

[Łukasz Anforowicz, 2016/06/01 16:28:38]

I guess we could also repeat the "assertion" from
NavigationControllerImpl::LoadURLWithParams which says something like
(pseudo-code): DCHECK_IMPLIES(method == "POST", url.SchemeIs(http or https)).

[Charlie Reis, 2016/06/01 23:46:32]

Sounds like a good idea.

[Łukasz Anforowicz, 2016/06/02 22:07:04]

I tried this in patchset 24, but it turns out that the new DCHECK failed for the
following case:
  url=chrome-extension://...
  method=POST
  body=1
The failure happened in navigator_impl.cc and in navigation_handle_impl.cc (but
I don't have at this point a specific repro for tickling this DCHECK in
navigation_params.cc).  Repro tests (browser_tests):
- InlineLoginUISafeIframeBrowserTest.ConfirmationRequiredForNonsecureSignin
- ExtensionWebRequestApiTest.PostData*

+}
 
 CommonNavigationParams::CommonNavigationParams(
     const CommonNavigationParams& other) = default;
 
 CommonNavigationParams::~CommonNavigationParams() {
 }
 
 BeginNavigationParams::BeginNavigationParams()
     : load_flags(0),
       has_user_gesture(false),
@@ skipping 108 matching lines @@
     const RequestNavigationParams& request_params)
     : common_params(common_params),
       start_params(start_params),
       request_params(request_params) {
 }
 
 NavigationParams::~NavigationParams() {
 }
 
 }  // namespace content