Forwarding POST body into renderer after a cross-site transfer.

content/browser/frame_host/navigation_entry_impl.h

Index: content/browser/frame_host/navigation_entry_impl.h
diff --git a/content/browser/frame_host/navigation_entry_impl.h b/content/browser/frame_host/navigation_entry_impl.h
index 8b5066e3e5dc986eab8195128327c4e715567084..2bfd0da383321dccb189c008fe44af12a6cd3f67 100644
--- a/content/browser/frame_host/navigation_entry_impl.h
+++ b/content/browser/frame_host/navigation_entry_impl.h
@@ -23,6 +23,7 @@
 #include "content/public/common/ssl_status.h"
 
 namespace content {
+class ResourceRequestBody;
 struct CommonNavigationParams;
 struct RequestNavigationParams;
 struct StartNavigationParams;
@@ -159,13 +160,16 @@ class CONTENT_EXPORT NavigationEntryImpl
 
   // Helper functions to construct NavigationParameters for a navigation to this
   // NavigationEntry.
+  scoped_refptr<ResourceRequestBody> ConstructResourceRequestBody() const;

[clamy, 2016/05/19 16:08:00]

Could we make it clearer that this is creating the body based on browser
initiated post data, and not based on data from the PageState? The naming is not
super clear there.

[Łukasz Anforowicz, 2016/05/19 18:06:58]

Thanks for the feedback.  I also wondered about this but had trouble coming up
with a good name.

ConstructBrowserInitiatedPostBody seems wrong - we are not constructing
BrowserInitiatedPostBody, we are converting BrowserInitiatedPostBody into
ResourceRequestBody.

ConstructResourceRequestBodyForBrowserInitiatedPost and
ConvertBrowserInitiatedPostDataIntoResourceRequestBody seem too long to be
readable.

Maybe ConstructBodyFromBrowserInitiatedPostData?

[clamy, 2016/05/20 15:49:14]

ConstructBodyFromBrowserInitiatedPostData sounds the best to me.

[Łukasz Anforowicz, 2016/05/20 22:18:47]

Acknowledged.  (the rename already happened in a previous patchset)

   CommonNavigationParams ConstructCommonNavigationParams(
+      const std::string& method,
       const GURL& dest_url,
       const Referrer& dest_referrer,
       FrameMsg_Navigate_Type::Value navigation_type,
       LoFiState lofi_state,
       const base::TimeTicks& navigation_start) const;
-  StartNavigationParams ConstructStartNavigationParams() const;
+  StartNavigationParams ConstructStartNavigationParams(
+      const scoped_refptr<ResourceRequestBody>& post_body) const;
   RequestNavigationParams ConstructRequestNavigationParams(
       const FrameNavigationEntry& frame_entry,
       bool is_same_document_history_load,