Forwarding POST body into renderer after a cross-site transfer.

content/browser/frame_host/navigation_entry_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
 
 #include <stdint.h>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_vector.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "content/browser/frame_host/frame_navigation_entry.h"
 #include "content/browser/frame_host/frame_tree_node.h"
 #include "content/browser/site_instance_impl.h"
 #include "content/common/frame_message_enums.h"
 #include "content/public/browser/favicon_status.h"
 #include "content/public/browser/global_request_id.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/common/page_state.h"
 #include "content/public/common/ssl_status.h"
 
 namespace content {
+class ResourceRequestBody;
 struct CommonNavigationParams;
 struct RequestNavigationParams;
 struct StartNavigationParams;
 
 class CONTENT_EXPORT NavigationEntryImpl
     : public NON_EXPORTED_BASE(NavigationEntry) {
  public:
   // Represents a tree of FrameNavigationEntries that make up this joint session
   // history item.  The tree currently only tracks the main frame by default,
   // and is populated with subframe nodes in --site-per-process mode.
@@ skipping 116 matching lines @@
   // TODO(creis): Once we start sharing FrameNavigationEntries between
   // NavigationEntryImpls, we will need to support two versions of Clone: one
   // that shares the existing FrameNavigationEntries (for use within the same
   // tab) and one that draws them from a different pool (for use in a new tab).
   std::unique_ptr<NavigationEntryImpl> CloneAndReplace(
       FrameTreeNode* frame_tree_node,
       FrameNavigationEntry* frame_entry) const;
 
   // Helper functions to construct NavigationParameters for a navigation to this
   // NavigationEntry.
+  scoped_refptr<ResourceRequestBody> ConstructResourceRequestBody() const;

[clamy, 2016/05/19 16:08:00]

Could we make it clearer that this is creating the body based on browser
initiated post data, and not based on data from the PageState? The naming is not
super clear there.

[Łukasz Anforowicz, 2016/05/19 18:06:58]

Thanks for the feedback.  I also wondered about this but had trouble coming up
with a good name.

ConstructBrowserInitiatedPostBody seems wrong - we are not constructing
BrowserInitiatedPostBody, we are converting BrowserInitiatedPostBody into
ResourceRequestBody.

ConstructResourceRequestBodyForBrowserInitiatedPost and
ConvertBrowserInitiatedPostDataIntoResourceRequestBody seem too long to be
readable.

Maybe ConstructBodyFromBrowserInitiatedPostData?

[clamy, 2016/05/20 15:49:14]

ConstructBodyFromBrowserInitiatedPostData sounds the best to me.

[Łukasz Anforowicz, 2016/05/20 22:18:47]

Acknowledged.  (the rename already happened in a previous patchset)

   CommonNavigationParams ConstructCommonNavigationParams(
+      const std::string& method,
       const GURL& dest_url,
       const Referrer& dest_referrer,
       FrameMsg_Navigate_Type::Value navigation_type,
       LoFiState lofi_state,
       const base::TimeTicks& navigation_start) const;
-  StartNavigationParams ConstructStartNavigationParams() const;
+  StartNavigationParams ConstructStartNavigationParams(
+      const scoped_refptr<ResourceRequestBody>& post_body) const;
   RequestNavigationParams ConstructRequestNavigationParams(
       const FrameNavigationEntry& frame_entry,
       bool is_same_document_history_load,
       bool has_committed_real_load,
       bool intended_as_new_entry,
       int pending_offset_to_send,
       int current_offset_to_send,
       int current_length_to_send) const;
 
   // Once a navigation entry is committed, we should no longer track several
@@ skipping 323 matching lines @@
   // persisted, unless specific data is taken out/put back in at save/restore
   // time (see TabNavigation for an example of this).
   std::map<std::string, base::string16> extra_data_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationEntryImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_