Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1956173002: Revert of network_time_tracker: add temporary time protocol. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of network_time_tracker: add temporary time protocol. (patchset #27 id:520001 of https://codereview.chromium.org/1835823002/ ) Reason for revert: Speculative; lots of browser tests started failing with leak reports, and all failing tests look network related. See https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/54004, e.g. [444:555:0506/185642:ERROR:leak_tracker.h(100)] #0 0x7fd9c5c00d0e base::debug::StackTrace::StackTrace() #1 0x00000186cf6f base::debug::LeakTracker<>::LeakTracker() #2 0x0000018635bb SystemURLRequestContextGetter::SystemURLRequestContextGetter() #3 0x000001865c21 IOThread::InitSystemRequestContext() #4 0x000001865af5 IOThread::system_url_request_context_getter() #5 0x000001a08b90 BrowserProcessImpl::system_request_context() #6 0x000001ef00c4 safe_browsing::SafeBrowsingService::Initialize() #7 0x000001a0c1b0 BrowserProcessImpl::CreateSafeBrowsingService() #8 0x000001a0c022 BrowserProcessImpl::safe_browsing_service() Original issue's description: > network_time_tracker: add temporary time protocol. > > This adds queries of the temporary secure time server, with signature > verification, and a very conservative scheduler. (Checks once per hour, > queries only if sync believed to be lost.) > > BUG=589700 > > Committed: https://crrev.com/ee2016a374b73ba35508ae26837755a23b3defa4 > Cr-Commit-Position: refs/heads/master@{#392208} TBR=estark@chromium.org,waffles@chromium.org,zea@chromium.org,sky@chromium.org,rohitrao@chromium.org,rsleevi@chromium.org,mmenke@chromium.org,rsesek@chromium.org,mab@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=589700 Committed: https://crrev.com/4373cd5db37927e07c87a3faf513682c88c13063 Cr-Commit-Position: refs/heads/master@{#392264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -579 lines) Patch
M chrome/browser/browser_process_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/client_update_protocol/ecdsa.h View 1 chunk +7 lines, -9 lines 0 comments Download
M components/client_update_protocol/ecdsa.cc View 1 chunk +1 line, -5 lines 0 comments Download
M components/client_update_protocol/ecdsa_unittest.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M components/network_time/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M components/network_time/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M components/network_time/network_time_tracker.h View 3 chunks +4 lines, -61 lines 0 comments Download
M components/network_time/network_time_tracker.cc View 6 chunks +2 lines, -229 lines 0 comments Download
M components/network_time/network_time_tracker_unittest.cc View 14 chunks +21 lines, -251 lines 0 comments Download
M components/ssl_errors/error_classification_unittest.cc View 2 chunks +1 line, -6 lines 0 comments Download
M ios/chrome/browser/application_context_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ios/chrome/test/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/test/testing_application_context.mm View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
Created Revert of network_time_tracker: add temporary time protocol.
4 years, 7 months ago (2016-05-07 17:49:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956173002/1
4 years, 7 months ago (2016-05-07 17:50:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-07 17:50:38 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4373cd5db37927e07c87a3faf513682c88c13063 Cr-Commit-Position: refs/heads/master@{#392264}
4 years, 7 months ago (2016-05-07 17:51:49 UTC) #6
Nico
4 years, 7 months ago (2016-05-07 19:29:07 UTC) #7
Message was sent while issue was closed.
On 2016/05/07 17:51:49, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/4373cd5db37927e07c87a3faf513682c88c13063
> Cr-Commit-Position: refs/heads/master@{#392264}

This helped.

Powered by Google App Engine
This is Rietveld 408576698