Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1956033002: Move hit testing of lines and floats to LayoutBlockFlow. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move hit testing of lines and floats to LayoutBlockFlow. BUG=302024 Committed: https://crrev.com/dd45dd525126806af124a1f4baa3634c9b33f344 Cr-Commit-Position: refs/heads/master@{#392311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -40 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +7 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +15 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-07 07:01:42 UTC) #2
leviw_travelin_and_unemployed
lgtm
4 years, 7 months ago (2016-05-09 01:20:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956033002/1
4 years, 7 months ago (2016-05-09 07:52:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/134032)
4 years, 7 months ago (2016-05-09 07:56:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956033002/1
4 years, 7 months ago (2016-05-09 08:43:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/224128)
4 years, 7 months ago (2016-05-09 09:50:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956033002/1
4 years, 7 months ago (2016-05-09 09:56:42 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/224156)
4 years, 7 months ago (2016-05-09 11:15:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956033002/1
4 years, 7 months ago (2016-05-09 13:32:25 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 14:31:07 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 14:32:32 UTC) #20
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dd45dd525126806af124a1f4baa3634c9b33f344
Cr-Commit-Position: refs/heads/master@{#392311}

Powered by Google App Engine
This is Rietveld 408576698