Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 1956033002: Move hit testing of lines and floats to LayoutBlockFlow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 317
318 int firstLineBoxBaseline() const override; 318 int firstLineBoxBaseline() const override;
319 int inlineBlockBaseline(LineDirectionMode) const override; 319 int inlineBlockBaseline(LineDirectionMode) const override;
320 320
321 // This function disables the 'overflow' check in inlineBlockBaseline. 321 // This function disables the 'overflow' check in inlineBlockBaseline.
322 // For 'inline-block', CSS says that the baseline is the bottom margin edge 322 // For 'inline-block', CSS says that the baseline is the bottom margin edge
323 // if 'overflow' is not visible. But some descendant classes want to ignore 323 // if 'overflow' is not visible. But some descendant classes want to ignore
324 // this condition. 324 // this condition.
325 virtual bool shouldIgnoreOverflowPropertyForInlineBlockBaseline() const { re turn false; } 325 virtual bool shouldIgnoreOverflowPropertyForInlineBlockBaseline() const { re turn false; }
326 326
327 bool hitTestChildren(HitTestResult&, const HitTestLocation& locationInContai ner, const LayoutPoint& accumulatedOffset, HitTestAction) override;
327 void updateHitTestResult(HitTestResult&, const LayoutPoint&) override; 328 void updateHitTestResult(HitTestResult&, const LayoutPoint&) override;
328 329
329 // Delay update scrollbar until finishDelayUpdateScrollInfo() will be 330 // Delay update scrollbar until finishDelayUpdateScrollInfo() will be
330 // called. This function is used when a flexbox is laying out its 331 // called. This function is used when a flexbox is laying out its
331 // descendant. If multiple calls are made to startDelayUpdateScrollInfo(), 332 // descendant. If multiple calls are made to startDelayUpdateScrollInfo(),
332 // finishDelayUpdateScrollInfo() will do nothing until finishDelayUpdateScro llInfo() 333 // finishDelayUpdateScrollInfo() will do nothing until finishDelayUpdateScro llInfo()
333 // is called the same number of times. 334 // is called the same number of times.
334 // finishDelayUpdateScrollInfo returns true when it marked something for lay out. 335 // finishDelayUpdateScrollInfo returns true when it marked something for lay out.
335 // It will also return a map of saved scroll positions that the caller shoul d restore 336 // It will also return a map of saved scroll positions that the caller shoul d restore
336 // on the given scrollable areas after performing the layout. 337 // on the given scrollable areas after performing the layout.
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
401 402
402 // Returns true if the positioned movement-only layout succeeded. 403 // Returns true if the positioned movement-only layout succeeded.
403 bool tryLayoutDoingPositionedMovementOnly(); 404 bool tryLayoutDoingPositionedMovementOnly();
404 405
405 bool avoidsFloats() const override { return true; } 406 bool avoidsFloats() const override { return true; }
406 407
407 bool isInSelfHitTestingPhase(HitTestAction hitTestAction) const final 408 bool isInSelfHitTestingPhase(HitTestAction hitTestAction) const final
408 { 409 {
409 return hitTestAction == HitTestBlockBackground || hitTestAction == HitTe stChildBlockBackground; 410 return hitTestAction == HitTestBlockBackground || hitTestAction == HitTe stChildBlockBackground;
410 } 411 }
411 bool hitTestChildren(HitTestResult&, const HitTestLocation& locationInContai ner, const LayoutPoint& accumulatedOffset, HitTestAction) override;
412 // FIXME-BLOCKFLOW: Remove virtualizaion when all callers have moved to Layo utBlockFlow
413 virtual bool hitTestFloats(HitTestResult&, const HitTestLocation&, const Lay outPoint&) { return false; }
414 412
415 bool isPointInOverflowControl(HitTestResult&, const LayoutPoint& locationInC ontainer, const LayoutPoint& accumulatedOffset) const; 413 bool isPointInOverflowControl(HitTestResult&, const LayoutPoint& locationInC ontainer, const LayoutPoint& accumulatedOffset) const;
416 414
417 void computeBlockPreferredLogicalWidths(LayoutUnit& minLogicalWidth, LayoutU nit& maxLogicalWidth) const; 415 void computeBlockPreferredLogicalWidths(LayoutUnit& minLogicalWidth, LayoutU nit& maxLogicalWidth) const;
418 416
419 LayoutObject* hoverAncestor() const final; 417 LayoutObject* hoverAncestor() const final;
420 void updateDragState(bool dragOn) final; 418 void updateDragState(bool dragOn) final;
421 void childBecameNonInline(LayoutObject* child) final; 419 void childBecameNonInline(LayoutObject* child) final;
422 420
423 bool isSelectionRoot() const; 421 bool isSelectionRoot() const;
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
505 // FIXME: This is temporary as we move code that accesses block flow 503 // FIXME: This is temporary as we move code that accesses block flow
506 // member variables out of LayoutBlock and into LayoutBlockFlow. 504 // member variables out of LayoutBlock and into LayoutBlockFlow.
507 friend class LayoutBlockFlow; 505 friend class LayoutBlockFlow;
508 }; 506 };
509 507
510 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock()); 508 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock());
511 509
512 } // namespace blink 510 } // namespace blink
513 511
514 #endif // LayoutBlock_h 512 #endif // LayoutBlock_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698