Fix for chromeRenderToAssociatedSink optional constraint calculation.

Fix for getUserMedia() chromeRenderToAssociatedSink optional audio constraint calculation.
If not specified (default) or set to 'true' => auto-selection of sink associated
with the input device is enabled. Whent set to 'false' => auto-selection is
disabled.
Fix proposed by hta@

Tested manually, works as expected.

BUG=

Committed: https://crrev.com/a5c22eadcefaa06df258876f6d43edf8d9e44269
Cr-Commit-Position: refs/heads/master@{#377882}

[o1ka, 2016-02-26 13:09:31]

Description was changed from

==========
Fix for chromeRenderToAssociatedSink optional constraint calculation.
If not specified (default) or set to 'true' => auto-selection of sink associated
with the input device is enabled. Whent set to 'false' => auto-selection is
disabled.
Fix proposed by hta@

BUG=
==========

to

==========
Fix for getUserMedia() chromeRenderToAssociatedSink optional audio constraint
calculation.
If not specified (default) or set to 'true' => auto-selection of sink associated
with the input device is enabled. Whent set to 'false' => auto-selection is
disabled.
Fix proposed by hta@

BUG=
==========

[o1ka, 2016-02-26 13:10:22]

olka@chromium.org changed reviewers:
+ hta@chromium.org, tommi@chromium.org

[o1ka, 2016-02-26 13:11:03]

Description was changed from

==========
Fix for getUserMedia() chromeRenderToAssociatedSink optional audio constraint
calculation.
If not specified (default) or set to 'true' => auto-selection of sink associated
with the input device is enabled. Whent set to 'false' => auto-selection is
disabled.
Fix proposed by hta@

BUG=
==========

to

==========
Fix for getUserMedia() chromeRenderToAssociatedSink optional audio constraint
calculation.
If not specified (default) or set to 'true' => auto-selection of sink associated
with the input device is enabled. Whent set to 'false' => auto-selection is
disabled.
Fix proposed by hta@

Tested manually, works as expected.

BUG=
==========

[tommi (sloooow) - chröme, 2016-02-26 13:12:56]

lgtm w/ 1 minor comment.

https://codereview.chromium.org/1741553003/diff/1/content/renderer/media/user...
File content/renderer/media/user_media_client_impl.cc (right):

https://codereview.chromium.org/1741553003/diff/1/content/renderer/media/user...
content/renderer/media/user_media_client_impl.cc:183: for (auto
advanced_constraint :
const auto&

[o1ka, 2016-02-26 13:20:40]

The CQ bit was checked by olka@chromium.org

[o1ka, 2016-02-26 13:20:40]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/1741553003/#ps20001
(title: "review comments addressed")

[commit-bot: I haz the power, 2016-02-26 13:20:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1741553003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1741553003/20001

[o1ka, 2016-02-26 13:21:06]

https://codereview.chromium.org/1741553003/diff/1/content/renderer/media/user...
File content/renderer/media/user_media_client_impl.cc (right):

https://codereview.chromium.org/1741553003/diff/1/content/renderer/media/user...
content/renderer/media/user_media_client_impl.cc:183: for (auto
advanced_constraint :
On 2016/02/26 13:12:56, tommi-chromium wrote:
> const auto&

Done.

[commit-bot: I haz the power, 2016-02-26 14:25:37]

Description was changed from

==========
Fix for getUserMedia() chromeRenderToAssociatedSink optional audio constraint
calculation.
If not specified (default) or set to 'true' => auto-selection of sink associated
with the input device is enabled. Whent set to 'false' => auto-selection is
disabled.
Fix proposed by hta@

Tested manually, works as expected.

BUG=
==========

to

==========
Fix for getUserMedia() chromeRenderToAssociatedSink optional audio constraint
calculation.
If not specified (default) or set to 'true' => auto-selection of sink associated
with the input device is enabled. Whent set to 'false' => auto-selection is
disabled.
Fix proposed by hta@

Tested manually, works as expected.

BUG=
==========

[commit-bot: I haz the power, 2016-02-26 14:25:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-26 14:27:34]

Description was changed from

==========
Fix for getUserMedia() chromeRenderToAssociatedSink optional audio constraint
calculation.
If not specified (default) or set to 'true' => auto-selection of sink associated
with the input device is enabled. Whent set to 'false' => auto-selection is
disabled.
Fix proposed by hta@

Tested manually, works as expected.

BUG=
==========

to

==========
Fix for getUserMedia() chromeRenderToAssociatedSink optional audio constraint
calculation.
If not specified (default) or set to 'true' => auto-selection of sink associated
with the input device is enabled. Whent set to 'false' => auto-selection is
disabled.
Fix proposed by hta@

Tested manually, works as expected.

BUG=

Committed: https://crrev.com/a5c22eadcefaa06df258876f6d43edf8d9e44269
Cr-Commit-Position: refs/heads/master@{#377882}
==========

[commit-bot: I haz the power, 2016-02-26 14:27:35]

Patchset 2 (id:??) landed as
https://crrev.com/a5c22eadcefaa06df258876f6d43edf8d9e44269
Cr-Commit-Position: refs/heads/master@{#377882}