Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1956023002: Revert of Simplify SkGpuBlurUtils::GaussianBlur method (Closed)

Created:
4 years, 7 months ago by jvanverth1
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Simplify SkGpuBlurUtils::GaussianBlur method (patchset #2 id:20001 of https://codereview.chromium.org/1958603002/ ) Reason for revert: Looks like it's causing some issues with the bleed_image GM. Original issue's description: > Simplify SkGpuBlurUtils::GaussianBlur method > > No one was using the canClobberSrc capability and moving the direct filtering case forward makes the rest of the logic simpler. > > Split out of: https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1958603002 > > Committed: https://skia.googlesource.com/skia/+/56a85e69a8d034e0fdee00e8207cda0a9da06fee TBR=bsalomon@google.com,robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/67a58dcd4a1e79e5832161ae953526d27893aa61

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -105 lines) Patch
M include/gpu/GrContext.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkGpuBlurUtils.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 5 chunks +99 lines, -98 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jvanverth1
Created Revert of Simplify SkGpuBlurUtils::GaussianBlur method
4 years, 7 months ago (2016-05-06 20:04:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956023002/1
4 years, 7 months ago (2016-05-06 20:05:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/67a58dcd4a1e79e5832161ae953526d27893aa61
4 years, 7 months ago (2016-05-06 20:05:13 UTC) #4
robertphillips
4 years, 7 months ago (2016-05-09 13:24:18 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1961953002/ by robertphillips@google.com.

The reason for reverting is: May not be as bad as was thought.

Powered by Google App Engine
This is Rietveld 408576698