[Autofill] Send events to fields being autofilled.

For input and textarea fields send these events:

Focus
KeyDown
Change (already present)
Input (already present)
KeyUp
Blur

For select fields send these events:

Focus
Change (already present)
Input (already present)
Blur

BUG=581537
TEST=AutofillInteractiveTest

Committed: https://crrev.com/4463586e3152ae8dec90f949a401b4695acf882c
Cr-Commit-Position: refs/heads/master@{#392842}

[sebsg, 2016-05-06 17:40:54]

Description was changed from

==========
[Autofill] Send events to fields being autofilled.

For input and textarea fields send these events:

Focus
KeyDown
Change (already present)
Input (already present)
KeyUp
Blur

For select fields send these events:

Focus
Change (already present)
Input (already present)
Blur

BUG=581537
TEST=AutofillInteractiveTest
==========

to

==========
For input and textarea fields send these events:

Focus
KeyDown
Change (already present)
Input (already present)
KeyUp
Blur

For select fields send these events:

Focus
Change (already present)
Input (already present)
Blur

BUG=581537
TEST=AutofillInteractiveTest
==========

[sebsg, 2016-05-06 17:46:16]

Patchset #1 (id:1) has been deleted

[sebsg, 2016-05-06 17:48:09]

sebsg@chromium.org changed reviewers:
+ mathp@chromium.org, tkent@chromium.org

[sebsg, 2016-05-06 17:48:10]

mathp@chromium.org: Could you please review the changes in chrome/* and
components/* ? 

tkent@chromium.org: Could you please review the changes in third_party/WebKit/*
?

Thanks!

[Mathieu, 2016-05-06 21:14:22]

Thanks, the autofill side lgtm. 

On the bug there is a question about not sending focus event if the focus is
already in the field? Are we doing that? If not, is it worth doing?

[tkent, 2016-05-09 01:54:21]

https://codereview.chromium.org/1955963002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLFormControlElement.h (right):

https://codereview.chromium.org/1955963002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLFormControlElement.h:66: void
dispatchKeyDownEvent();
Can you move these two functions to WebFormControlElement?
I'd like to reduce changes to Source/core/ in this CL.

https://codereview.chromium.org/1955963002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebFormControlElement.cpp (right):

https://codereview.chromium.org/1955963002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebFormControlElement.cpp:103: if
(isHTMLInputElement(*m_private)) {
- You can unify HTMLInputElement path and HTMLTextAreaElement path.
- dispatchFocusEvent and dispatchBlurEvent are public on Element

if (isHTMLTextFormControlElement(*m_private) {
    unwrap<Element>()->dispatchFocusEvent(...);
    dispatchKeyDownEvent();
    unwrap<HTMLTextFormControlElement>()->setValue(...);
    dispatchKeyUpEvent();
    unwrap<Element>()->dispatchBlurEvent(...);
} else if (isHTMLSelectElement(*m_private)) ...

[sebsg, 2016-05-09 16:42:23]

Patchset #2 (id:40001) has been deleted

[sebsg, 2016-05-09 17:23:20]

Patchset #3 (id:80001) has been deleted

[sebsg, 2016-05-09 17:26:15]

Patchset #3 (id:100001) has been deleted

[sebsg, 2016-05-09 21:27:43]

Patchset #3 (id:120001) has been deleted

[sebsg, 2016-05-09 21:32:31]

Patchset #3 (id:140001) has been deleted

[sebsg, 2016-05-09 22:19:11]

Thanks for the comments, could you please take another look?

https://codereview.chromium.org/1955963002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLFormControlElement.h (right):

https://codereview.chromium.org/1955963002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLFormControlElement.h:66: void
dispatchKeyDownEvent();
On 2016/05/09 01:54:21, tkent wrote:
> Can you move these two functions to WebFormControlElement?
> I'd like to reduce changes to Source/core/ in this CL.

Done.

https://codereview.chromium.org/1955963002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebFormControlElement.cpp (right):

https://codereview.chromium.org/1955963002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebFormControlElement.cpp:103: if
(isHTMLInputElement(*m_private)) {
On 2016/05/09 01:54:21, tkent wrote:
> - You can unify HTMLInputElement path and HTMLTextAreaElement path.
> - dispatchFocusEvent and dispatchBlurEvent are public on Element
> 
> if (isHTMLTextFormControlElement(*m_private) {
>     unwrap<Element>()->dispatchFocusEvent(...);
>     dispatchKeyDownEvent();
>     unwrap<HTMLTextFormControlElement>()->setValue(...);
>     dispatchKeyUpEvent();
>     unwrap<Element>()->dispatchBlurEvent(...);
> } else if (isHTMLSelectElement(*m_private)) ...

Nice! I merged the calls but kept the if more restrictive to only fill inputs
and textarea fields like before. Thanks!

[tkent, 2016-05-09 23:26:33]

looks ok.  As mathp wrote, probably it's safer to skip focus/blur if the element
is already focused.

[sebsg, 2016-05-10 15:23:37]

Patchset #4 (id:180001) has been deleted

[sebsg, 2016-05-10 15:24:04]

I just added the focus check, thanks!

[tkent, 2016-05-10 23:55:55]

lgtm

[sebsg, 2016-05-11 02:07:53]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2016-05-11 02:07:54]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/1955963002/#ps200001
(title: "Added focus check")

[commit-bot: I haz the power, 2016-05-11 02:08:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955963002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955963002/200001

[commit-bot: I haz the power, 2016-05-11 03:45:02]

Description was changed from

==========
For input and textarea fields send these events:

Focus
KeyDown
Change (already present)
Input (already present)
KeyUp
Blur

For select fields send these events:

Focus
Change (already present)
Input (already present)
Blur

BUG=581537
TEST=AutofillInteractiveTest
==========

to

==========
For input and textarea fields send these events:

Focus
KeyDown
Change (already present)
Input (already present)
KeyUp
Blur

For select fields send these events:

Focus
Change (already present)
Input (already present)
Blur

BUG=581537
TEST=AutofillInteractiveTest
==========

[commit-bot: I haz the power, 2016-05-11 03:45:03]

Committed patchset #4 (id:200001)

[commit-bot: I haz the power, 2016-05-11 03:46:33]

Description was changed from

==========
For input and textarea fields send these events:

Focus
KeyDown
Change (already present)
Input (already present)
KeyUp
Blur

For select fields send these events:

Focus
Change (already present)
Input (already present)
Blur

BUG=581537
TEST=AutofillInteractiveTest
==========

to

==========
For input and textarea fields send these events:

Focus
KeyDown
Change (already present)
Input (already present)
KeyUp
Blur

For select fields send these events:

Focus
Change (already present)
Input (already present)
Blur

BUG=581537
TEST=AutofillInteractiveTest

Committed: https://crrev.com/4463586e3152ae8dec90f949a401b4695acf882c
Cr-Commit-Position: refs/heads/master@{#392842}
==========

[commit-bot: I haz the power, 2016-05-11 03:46:34]

Patchset 4 (id:??) landed as
https://crrev.com/4463586e3152ae8dec90f949a401b4695acf882c
Cr-Commit-Position: refs/heads/master@{#392842}