tools/buildbot_spec.py - Issue 1955923002: Disable skia_warnings_as_errors for Fast bot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/buildbot_spec.py

Issue 1955923002: Disable skia_warnings_as_errors for Fast bot. (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/buildbot_spec.py

diff --git a/tools/buildbot_spec.py b/tools/buildbot_spec.py

index edc05f0b0344a1f6e8f3df57c08cc85b1f2bc428..c1271ee41054df80b21a6bd68ae6cb103d489ba7 100755

--- a/tools/buildbot_spec.py

+++ b/tools/buildbot_spec.py

@@ -80,6 +80,9 @@ def gyp_defines(builder_dict):

elif ('Mac' in builder_dict.get('os', '') and

'Android' in builder_dict.get('extra_config', '')):

werr = False

+ elif 'Fast' in builder_dict.get('extra_config', ''):

+ # See https://bugs.chromium.org/p/skia/issues/detail?id=5257

+ werr = False

else:

werr = True

gyp_defs['skia_warnings_as_errors'] = str(int(werr)) # True/False -> '1'/'0'

« no previous file with comments | « no previous file | no next file » | no next file with comments »