Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: tools/buildbot_spec.py

Issue 1955923002: Disable skia_warnings_as_errors for Fast bot. (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # 1 #
2 # Copyright 2015 Google Inc. 2 # Copyright 2015 Google Inc.
3 # 3 #
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 # 6 #
7 7
8 #!/usr/bin/env python 8 #!/usr/bin/env python
9 9
10 usage = ''' 10 usage = '''
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 # skia_warnings_as_errors. 73 # skia_warnings_as_errors.
74 werr = False 74 werr = False
75 if builder_dict['role'] == builder_name_schema.BUILDER_ROLE_BUILD: 75 if builder_dict['role'] == builder_name_schema.BUILDER_ROLE_BUILD:
76 if 'Win' in builder_dict.get('os', ''): 76 if 'Win' in builder_dict.get('os', ''):
77 if not ('GDI' in builder_dict.get('extra_config', '') or 77 if not ('GDI' in builder_dict.get('extra_config', '') or
78 'Exceptions' in builder_dict.get('extra_config', '')): 78 'Exceptions' in builder_dict.get('extra_config', '')):
79 werr = True 79 werr = True
80 elif ('Mac' in builder_dict.get('os', '') and 80 elif ('Mac' in builder_dict.get('os', '') and
81 'Android' in builder_dict.get('extra_config', '')): 81 'Android' in builder_dict.get('extra_config', '')):
82 werr = False 82 werr = False
83 elif 'Fast' in builder_dict.get('extra_config', ''):
84 # See https://bugs.chromium.org/p/skia/issues/detail?id=5257
85 werr = False
83 else: 86 else:
84 werr = True 87 werr = True
85 gyp_defs['skia_warnings_as_errors'] = str(int(werr)) # True/False -> '1'/'0' 88 gyp_defs['skia_warnings_as_errors'] = str(int(werr)) # True/False -> '1'/'0'
86 89
87 # Win debugger. 90 # Win debugger.
88 if 'Win' in builder_dict.get('os', ''): 91 if 'Win' in builder_dict.get('os', ''):
89 gyp_defs['skia_win_debuggers_path'] = 'c:/DbgHelp' 92 gyp_defs['skia_win_debuggers_path'] = 'c:/DbgHelp'
90 93
91 # Qt SDK (Win). 94 # Qt SDK (Win).
92 if 'Win' in builder_dict.get('os', ''): 95 if 'Win' in builder_dict.get('os', ''):
(...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after
401 if len(sys.argv) == 2 and sys.argv[1] == 'test': 404 if len(sys.argv) == 2 and sys.argv[1] == 'test':
402 self_test() 405 self_test()
403 sys.exit(0) 406 sys.exit(0)
404 407
405 if len(sys.argv) != 3: 408 if len(sys.argv) != 3:
406 print usage 409 print usage
407 sys.exit(1) 410 sys.exit(1)
408 411
409 with open(sys.argv[1], 'w') as out: 412 with open(sys.argv[1], 'w') as out:
410 json.dump(get_builder_spec(sys.argv[2]), out) 413 json.dump(get_builder_spec(sys.argv[2]), out)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698