Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: media/mojo/services/mojo_renderer_impl.h

Issue 1955843002: Move Renderer permanent callbacks into RendererClient interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/video_renderer.h ('k') | media/mojo/services/mojo_renderer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/mojo_renderer_impl.h
diff --git a/media/mojo/services/mojo_renderer_impl.h b/media/mojo/services/mojo_renderer_impl.h
index 9a7bb0f92a21a7241b4f8d30c6adcf9e39e539ca..bd92e39cfe8823cc623c8016bd2fcdbfbf5c4263 100644
--- a/media/mojo/services/mojo_renderer_impl.h
+++ b/media/mojo/services/mojo_renderer_impl.h
@@ -39,12 +39,8 @@ class MojoRendererImpl : public Renderer, public interfaces::RendererClient {
// Renderer implementation.
void Initialize(DemuxerStreamProvider* demuxer_stream_provider,
- const PipelineStatusCB& init_cb,
- const StatisticsCB& statistics_cb,
- const BufferingStateCB& buffering_state_cb,
- const base::Closure& ended_cb,
- const PipelineStatusCB& error_cb,
- const base::Closure& waiting_for_decryption_key_cb) override;
+ media::RendererClient* client,
+ const PipelineStatusCB& init_cb) override;
void SetCdm(CdmContext* cdm_context,
const CdmAttachedCB& cdm_attached_cb) override;
void Flush(const base::Closure& flush_cb) override;
@@ -77,6 +73,9 @@ class MojoRendererImpl : public Renderer, public interfaces::RendererClient {
// lifetime of |this|.
DemuxerStreamProvider* demuxer_stream_provider_;
+ // Client of |this| renderer passed in Initialize.
+ media::RendererClient* client_;
+
// This class is constructed on one thread and used exclusively on another
// thread. This member is used to safely pass the RendererPtr from one thread
// to another. It is set in the constructor and is consumed in Initialize().
@@ -91,9 +90,6 @@ class MojoRendererImpl : public Renderer, public interfaces::RendererClient {
// Callbacks passed to Initialize() that we forward messages from
// |remote_renderer_| through.
PipelineStatusCB init_cb_;
- base::Closure ended_cb_;
- PipelineStatusCB error_cb_;
- BufferingStateCB buffering_state_cb_;
// Lock used to serialize access for |time_|.
mutable base::Lock lock_;
« no previous file with comments | « media/base/video_renderer.h ('k') | media/mojo/services/mojo_renderer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698