Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Side by Side Diff: media/mojo/services/mojo_renderer_impl.h

Issue 1955843002: Move Renderer permanent callbacks into RendererClient interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/base/video_renderer.h ('k') | media/mojo/services/mojo_renderer_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_MOJO_SERVICES_MOJO_RENDERER_IMPL_H_ 5 #ifndef MEDIA_MOJO_SERVICES_MOJO_RENDERER_IMPL_H_
6 #define MEDIA_MOJO_SERVICES_MOJO_RENDERER_IMPL_H_ 6 #define MEDIA_MOJO_SERVICES_MOJO_RENDERER_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 21 matching lines...) Expand all
32 // which can be called on any thread. 32 // which can be called on any thread.
33 class MojoRendererImpl : public Renderer, public interfaces::RendererClient { 33 class MojoRendererImpl : public Renderer, public interfaces::RendererClient {
34 public: 34 public:
35 MojoRendererImpl( 35 MojoRendererImpl(
36 const scoped_refptr<base::SingleThreadTaskRunner>& task_runner, 36 const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
37 interfaces::RendererPtr remote_renderer); 37 interfaces::RendererPtr remote_renderer);
38 ~MojoRendererImpl() override; 38 ~MojoRendererImpl() override;
39 39
40 // Renderer implementation. 40 // Renderer implementation.
41 void Initialize(DemuxerStreamProvider* demuxer_stream_provider, 41 void Initialize(DemuxerStreamProvider* demuxer_stream_provider,
42 const PipelineStatusCB& init_cb, 42 media::RendererClient* client,
43 const StatisticsCB& statistics_cb, 43 const PipelineStatusCB& init_cb) override;
44 const BufferingStateCB& buffering_state_cb,
45 const base::Closure& ended_cb,
46 const PipelineStatusCB& error_cb,
47 const base::Closure& waiting_for_decryption_key_cb) override;
48 void SetCdm(CdmContext* cdm_context, 44 void SetCdm(CdmContext* cdm_context,
49 const CdmAttachedCB& cdm_attached_cb) override; 45 const CdmAttachedCB& cdm_attached_cb) override;
50 void Flush(const base::Closure& flush_cb) override; 46 void Flush(const base::Closure& flush_cb) override;
51 void StartPlayingFrom(base::TimeDelta time) override; 47 void StartPlayingFrom(base::TimeDelta time) override;
52 void SetPlaybackRate(double playback_rate) override; 48 void SetPlaybackRate(double playback_rate) override;
53 void SetVolume(float volume) override; 49 void SetVolume(float volume) override;
54 base::TimeDelta GetMediaTime() override; 50 base::TimeDelta GetMediaTime() override;
55 bool HasAudio() override; 51 bool HasAudio() override;
56 bool HasVideo() override; 52 bool HasVideo() override;
57 53
(...skipping 12 matching lines...) Expand all
70 void OnInitialized(bool success); 66 void OnInitialized(bool success);
71 67
72 // |task_runner| on which all methods are invoked, except for GetMediaTime(), 68 // |task_runner| on which all methods are invoked, except for GetMediaTime(),
73 // which can be called on any thread. 69 // which can be called on any thread.
74 scoped_refptr<base::SingleThreadTaskRunner> task_runner_; 70 scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
75 71
76 // Provider of audio/video DemuxerStreams. Must be valid throughout the 72 // Provider of audio/video DemuxerStreams. Must be valid throughout the
77 // lifetime of |this|. 73 // lifetime of |this|.
78 DemuxerStreamProvider* demuxer_stream_provider_; 74 DemuxerStreamProvider* demuxer_stream_provider_;
79 75
76 // Client of |this| renderer passed in Initialize.
77 media::RendererClient* client_;
78
80 // This class is constructed on one thread and used exclusively on another 79 // This class is constructed on one thread and used exclusively on another
81 // thread. This member is used to safely pass the RendererPtr from one thread 80 // thread. This member is used to safely pass the RendererPtr from one thread
82 // to another. It is set in the constructor and is consumed in Initialize(). 81 // to another. It is set in the constructor and is consumed in Initialize().
83 interfaces::RendererPtrInfo remote_renderer_info_; 82 interfaces::RendererPtrInfo remote_renderer_info_;
84 83
85 // Remote Renderer, bound to |task_runner_| during Initialize(). 84 // Remote Renderer, bound to |task_runner_| during Initialize().
86 interfaces::RendererPtr remote_renderer_; 85 interfaces::RendererPtr remote_renderer_;
87 86
88 // Binding for RendererClient, bound to the |task_runner_|. 87 // Binding for RendererClient, bound to the |task_runner_|.
89 mojo::Binding<RendererClient> binding_; 88 mojo::Binding<RendererClient> binding_;
90 89
91 // Callbacks passed to Initialize() that we forward messages from 90 // Callbacks passed to Initialize() that we forward messages from
92 // |remote_renderer_| through. 91 // |remote_renderer_| through.
93 PipelineStatusCB init_cb_; 92 PipelineStatusCB init_cb_;
94 base::Closure ended_cb_;
95 PipelineStatusCB error_cb_;
96 BufferingStateCB buffering_state_cb_;
97 93
98 // Lock used to serialize access for |time_|. 94 // Lock used to serialize access for |time_|.
99 mutable base::Lock lock_; 95 mutable base::Lock lock_;
100 base::TimeDelta time_; 96 base::TimeDelta time_;
101 97
102 DISALLOW_COPY_AND_ASSIGN(MojoRendererImpl); 98 DISALLOW_COPY_AND_ASSIGN(MojoRendererImpl);
103 }; 99 };
104 100
105 } // namespace media 101 } // namespace media
106 102
107 #endif // MEDIA_MOJO_SERVICES_MOJO_RENDERER_IMPL_H_ 103 #endif // MEDIA_MOJO_SERVICES_MOJO_RENDERER_IMPL_H_
OLDNEW
« no previous file with comments | « media/base/video_renderer.h ('k') | media/mojo/services/mojo_renderer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698