Implement font-variant-numeric

Implement font-variant-numeric

Now that we have font-variant converted to be a shorthand, we can base
an implementation of font-variant-numeric on top.

This CL implements the font-variant-numeric property, integrates it with
the font-variant shorthand, implements the required OpenType mappings
and activates the feature in HarfBuzz as needed. Tests added and
extended accordingly.

Intent to Implement and Ship thread on blink-dev:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/osZzOCF-ONM

BUG=609813
Committed: https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b
Cr-Commit-Position: refs/heads/master@{#393534}

[drott, 2016-05-06 13:11:18]

drott@chromium.org changed reviewers:
+ eae@chromium.org, timloh@chromium.org

[drott, 2016-05-06 13:11:30]

PTAL, thanks.

[drott, 2016-05-06 13:19:56]

Remove whitespace and clarified TODOs

[eae, 2016-05-09 16:31:58]

LGTM

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/FontDescription.h (right):

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/FontDescription.h:52: uint32_t f[2];
part or segment might be a better name than f. None of them area great though.
Perhaps using a 64bit int instead would be better?

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/FontVariantNumeric.h (right):

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/FontVariantNumeric.h:58: NumericFigure
numericFigure() const { return
static_cast<NumericFigure>(m_fields.m_numericFigure); }
Methods and enums should use names that differ by more than case given that the
new blink style guide will rename methods to use CapitalizedCase thus causing a
potential conflict here.

[Timothy Loh, 2016-05-10 05:26:26]

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:548: class
VariantNumericValidator {
Why is this different to the ligatures parser? Shouldn't we just build the list
here too?

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/resolver/FontBuilderTest.cpp (right):

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/FontBuilderTest.cpp:118: static void
fontVariantNumericBase(FontDescription &d) {
d.setVariantNumeric(FontVariantNumeric()); }
& before the space

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
(right):

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp:343: if
(value.isValueList()) {
I would put the 'none' check up first, i.e.

if (value.isPrimitiveValue()) {
    ASSERT(... == CSSValueNone);
    return ...;
}

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp:346: for
(size_t i = 0; i < valueList.length(); ++i) {
for (const CSSValue* feature : toCSSValueList(value))

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp:382:
ASSERT_WITH_SECURITY_IMPLICATION(value.isPrimitiveValue());
btw this line is redundant because toCSSPrimitiveValue has this exact assertion

[drott, 2016-05-10 09:18:03]

Review comments addressed

[drott, 2016-05-10 10:58:15]

eae@'s review comments addressed

[drott, 2016-05-10 10:59:06]

Thanks for the review, Tim and Emil - comments addressed.

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:548: class
VariantNumericValidator {
On 2016/05/10 at 05:26:25, Timothy Loh wrote:
> Why is this different to the ligatures parser? Shouldn't we just build the
list here too?

It should, changed this to contain and build the value list.

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/resolver/FontBuilderTest.cpp (right):

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/FontBuilderTest.cpp:118: static void
fontVariantNumericBase(FontDescription &d) {
d.setVariantNumeric(FontVariantNumeric()); }
On 2016/05/10 at 05:26:25, Timothy Loh wrote:
> & before the space

Done.

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
(right):

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp:343: if
(value.isValueList()) {
On 2016/05/10 at 05:26:26, Timothy Loh wrote:
> I would put the 'none' check up first, i.e.
> 
> if (value.isPrimitiveValue()) {
>     ASSERT(... == CSSValueNone);
>     return ...;
> }

I assume you meant the "normal" check? Done.

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp:346: for
(size_t i = 0; i < valueList.length(); ++i) {
On 2016/05/10 at 05:26:26, Timothy Loh wrote:
> for (const CSSValue* feature : toCSSValueList(value))

Changed accordingly.

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp:382:
ASSERT_WITH_SECURITY_IMPLICATION(value.isPrimitiveValue());
On 2016/05/10 at 05:26:26, Timothy Loh wrote:
> btw this line is redundant because toCSSPrimitiveValue has this exact
assertion

Not needed anymore due to the inversed order of checks.

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/FontDescription.h (right):

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/FontDescription.h:52: uint32_t f[2];
On 2016/05/09 at 16:31:58, eae wrote:
> part or segment might be a better name than f. None of them area great though.
Perhaps using a 64bit int instead would be better?

Renamed to 'parts' to indicate it's an array.

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/FontVariantNumeric.h (right):

https://codereview.chromium.org/1955723004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/FontVariantNumeric.h:58: NumericFigure
numericFigure() const { return
static_cast<NumericFigure>(m_fields.m_numericFigure); }
On 2016/05/09 at 16:31:58, eae wrote:
> Methods and enums should use names that differ by more than case given that
the new blink style guide will rename methods to use CapitalizedCase thus
causing a potential conflict here.

Suffixed with Value() for all accessors.

[Timothy Loh, 2016-05-11 06:47:26]

Bots are red, there are a whole bunch of tests that need to be updated or
rebaselined.

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-numeric.html
(right):

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-numeric.html:18:
</script>
Can we just testRunner.dumpAsText() to avoid the need for platform-specific
pixel and layout tree expectation?

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-shorthand.html
(right):

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-shorthand.html:6:
var shorthandWriteExpectations = [
I think we should have at least one test here where the different longhands are
intertwined (e.g. lining-nums historical-ligatures ordinal all-small-caps)

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:4081:
addProperty(CSSPropertyLineHeight, CSSPropertyFont,
cssValuePool().createIdentifierValue(CSSValueNormal), important);
this function needs to be updated too

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
(right):

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp:348:
ASSERT_WITH_SECURITY_IMPLICATION(value.isValueList());
No need to write this, toCSSValueList has this assertion

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/FontVariantNumeric.h (right):

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/FontVariantNumeric.h:18: NormalFigure =
0,
Is there any reason to explicitly number these? By default they will be given
exactly the same values.

[drott, 2016-05-11 08:06:43]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[drott, 2016-05-11 08:06:50]

Review comments addressed, test expectations updated

[commit-bot: I haz the power, 2016-05-11 08:06:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955723004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955723004/80001

[drott, 2016-05-11 08:10:47]

Thanks for the review, CL updated.

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-numeric.html
(right):

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-numeric.html:18:
</script>
On 2016/05/11 at 06:47:25, Timothy Loh wrote:
> Can we just testRunner.dumpAsText() to avoid the need for platform-specific
pixel and layout tree expectation?

No, because the PASS, FAIL results are single glyphs, but I forgot that this was
meant to be a reftest. Uploaded and added the corresponding expectation.

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-shorthand.html
(right):

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-shorthand.html:6:
var shorthandWriteExpectations = [
On 2016/05/11 at 06:47:26, Timothy Loh wrote:
> I think we should have at least one test here where the different longhands
are intertwined (e.g. lining-nums historical-ligatures ordinal all-small-caps)

Added two of those.

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:4081:
addProperty(CSSPropertyLineHeight, CSSPropertyFont,
cssValuePool().createIdentifierValue(CSSValueNormal), important);
On 2016/05/11 at 06:47:26, Timothy Loh wrote:
> this function needs to be updated too

Added the reset for numeric here.

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
(right):

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp:348:
ASSERT_WITH_SECURITY_IMPLICATION(value.isValueList());
On 2016/05/11 at 06:47:26, Timothy Loh wrote:
> No need to write this, toCSSValueList has this assertion

Assertion removed.

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/FontVariantNumeric.h (right):

https://codereview.chromium.org/1955723004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/FontVariantNumeric.h:18: NormalFigure =
0,
On 2016/05/11 at 06:47:26, Timothy Loh wrote:
> Is there any reason to explicitly number these? By default they will be given
exactly the same values.

For the isAllNormal() check we need the default values to be 0 and I think it
helps with reading the code to highlight such in the enum values explicitly.
Other explicit numbering removed.

[commit-bot: I haz the power, 2016-05-11 09:22:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 09:22:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[drott, 2016-05-11 11:20:24]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[drott, 2016-05-11 11:20:26]

font-shorthand rebaselined

[commit-bot: I haz the power, 2016-05-11 11:20:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955723004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955723004/100001

[commit-bot: I haz the power, 2016-05-11 12:47:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 12:47:12]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2016-05-12 07:24:42]

lgtm

https://codereview.chromium.org/1955723004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1955723004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:4176: CSSValueID
id = m_range.peek().id();
This line doesn't need to move

[drott, 2016-05-12 07:38:11]

Line moved back

[drott, 2016-05-12 07:38:55]

drott@chromium.org changed reviewers:
+ dpranke@chromium.org, mpearson@chromium.org

[drott, 2016-05-12 07:39:30]

dpranke@chromium.org, mpearson@chromium.org, could you please review the changes
in 
   
third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
    tools/metrics/histograms/histograms.xml

[drott, 2016-05-12 07:39:33]

The CQ bit was checked by drott@chromium.org

[drott, 2016-05-12 07:39:34]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org,
timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1955723004/#ps120001
(title: "Line moved back")

[commit-bot: I haz the power, 2016-05-12 07:39:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955723004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955723004/120001

[Timothy Loh, 2016-05-12 07:45:35]

One more quick thing, we should link to the intent thread somewhere either in
the patch description or bug (or both).

[commit-bot: I haz the power, 2016-05-12 07:46:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 07:46:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[drott, 2016-05-12 07:47:22]

Description was changed from

==========
Implement font-variant-numeric

Now that we have font-variant converted to be a shorthand, we can base
an implementation of font-variant-numeric on top.

This CL implements the font-variant-numeric property, integrates it with
the font-variant shorthand, implements the required OpenType mappings
and activates the feature in HarfBuzz as needed. Tests added and
extended accordingly.

BUG=609813
==========

to

==========
Implement font-variant-numeric

Now that we have font-variant converted to be a shorthand, we can base
an implementation of font-variant-numeric on top.

This CL implements the font-variant-numeric property, integrates it with
the font-variant shorthand, implements the required OpenType mappings
and activates the feature in HarfBuzz as needed. Tests added and
extended accordingly.

Intent to Implement and Ship thread on blink-dev:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/osZzOCF-ONM


BUG=609813
==========

[drott, 2016-05-12 07:47:22]

drott@chromium.org changed reviewers:
- dpranke@chromium.org, mpearson@chromium.org

[drott, 2016-05-12 07:47:31]

Description was changed from

==========
Implement font-variant-numeric

Now that we have font-variant converted to be a shorthand, we can base
an implementation of font-variant-numeric on top.

This CL implements the font-variant-numeric property, integrates it with
the font-variant shorthand, implements the required OpenType mappings
and activates the feature in HarfBuzz as needed. Tests added and
extended accordingly.

Intent to Implement and Ship thread on blink-dev:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/osZzOCF-ONM


BUG=609813
==========

to

==========
Implement font-variant-numeric

Now that we have font-variant converted to be a shorthand, we can base
an implementation of font-variant-numeric on top.

This CL implements the font-variant-numeric property, integrates it with
the font-variant shorthand, implements the required OpenType mappings
and activates the feature in HarfBuzz as needed. Tests added and
extended accordingly.

Intent to Implement and Ship thread on blink-dev:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/osZzOCF-ONM

BUG=609813
==========

[drott, 2016-05-12 07:48:05]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 07:48:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955723004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955723004/120001

[commit-bot: I haz the power, 2016-05-12 09:14:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 09:15:00]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-05-13 01:37:50]

On 2016/05/12 07:39:30, drott wrote:
> mailto:dpranke@chromium.org, mailto:mpearson@chromium.org, could you please
review the changes
> in 
>    
>
third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
>     tools/metrics/histograms/histograms.xml

I'm not an owner for webexposed; I suggest dglazkov@ or tkent@.

[drott, 2016-05-13 08:30:43]

drott@chromium.org changed reviewers:
+ dglazkov@chromium.org, tkent@chromium.org

[drott, 2016-05-13 08:31:26]

On 2016/05/13 at 01:37:50, dpranke wrote:
 
> I'm not an owner for webexposed; I suggest dglazkov@ or tkent@.

dglazkov@ or tkent@, could you review the changes in 
third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
tools/metrics/histograms/histograms.xml

Thanks.

[tkent, 2016-05-13 08:44:12]

lgtm.

I'm not an owner of histograms.xml.

https://codereview.chromium.org/1955723004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/fonts/FontDescription.h (right):

https://codereview.chromium.org/1955723004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/fonts/FontDescription.h:241: // FIXME: We
should not expose internal structure here, but rather introduce
FIXME: -> TODO():

[drott, 2016-05-13 09:13:53]

drott@chromium.org changed reviewers:
+ asvitkine@chromium.org, holte@chromium.org, isherman@chromium.org,
jwd@chromium.org, mpearson@chromium.org, rkaplow@chromium.org

[drott, 2016-05-13 09:14:28]

asvitkine@, holte@, isherman@, jwd@, mpearson@, rkaplow@, can anyone of you
review the histograms.xml change? Thank you.

[drott, 2016-05-13 11:39:30]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[drott, 2016-05-13 11:39:34]

FIXME -> TODO

[commit-bot: I haz the power, 2016-05-13 11:39:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955723004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955723004/140001

[commit-bot: I haz the power, 2016-05-13 13:21:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 13:21:23]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2016-05-13 14:12:40]

lgtm

histogram lgtm

[drott, 2016-05-13 14:13:42]

rkaplow, thanks!

[drott, 2016-05-13 14:14:01]

The CQ bit was checked by drott@chromium.org

[drott, 2016-05-13 14:14:02]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
timloh@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1955723004/#ps140001
(title: "FIXME -> TODO")

[commit-bot: I haz the power, 2016-05-13 14:14:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955723004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955723004/140001

[commit-bot: I haz the power, 2016-05-13 14:22:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 14:22:37]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[drott, 2016-05-13 14:26:22]

rebased

[drott, 2016-05-13 14:26:31]

The CQ bit was checked by drott@chromium.org

[drott, 2016-05-13 14:26:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
rkaplow@chromium.org, tkent@chromium.org, timloh@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1955723004/#ps160001
(title: "rebased")

[commit-bot: I haz the power, 2016-05-13 14:26:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955723004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955723004/160001

[commit-bot: I haz the power, 2016-05-13 16:03:29]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-05-13 16:05:05]

Description was changed from

==========
Implement font-variant-numeric

Now that we have font-variant converted to be a shorthand, we can base
an implementation of font-variant-numeric on top.

This CL implements the font-variant-numeric property, integrates it with
the font-variant shorthand, implements the required OpenType mappings
and activates the feature in HarfBuzz as needed. Tests added and
extended accordingly.

Intent to Implement and Ship thread on blink-dev:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/osZzOCF-ONM

BUG=609813
==========

to

==========
Implement font-variant-numeric

Now that we have font-variant converted to be a shorthand, we can base
an implementation of font-variant-numeric on top.

This CL implements the font-variant-numeric property, integrates it with
the font-variant shorthand, implements the required OpenType mappings
and activates the feature in HarfBuzz as needed. Tests added and
extended accordingly.

Intent to Implement and Ship thread on blink-dev:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/osZzOCF-ONM

BUG=609813

Committed: https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b
Cr-Commit-Position: refs/heads/master@{#393534}
==========

[commit-bot: I haz the power, 2016-05-13 16:05:08]

Patchset 9 (id:??) landed as
https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b
Cr-Commit-Position: refs/heads/master@{#393534}