third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-numeric.html - Issue 1955723004: Implement font-variant-numeric

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-numeric.html

Issue 1955723004: Implement font-variant-numeric (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: eae@'s review comments addressed Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/font-variant-shorthand-from-longhands-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-shorthand.html » ('j') | third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-shorthand.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <!-- Test case adapted from Mozilla tests for font-variant-subproperties availab le under	2 <!-- Test case adapted from Mozilla tests for font-variant-subproperties availab le under

3 http://creativecommons.org/publicdomain/zero/1.0/	3 http://creativecommons.org/publicdomain/zero/1.0/

4 See discussion on https://bugzilla.mozilla.org/show_bug.cgi?id=1261445	4 See discussion on https://bugzilla.mozilla.org/show_bug.cgi?id=1261445

5 -->	5 -->

6 <html lang="en">	6 <html lang="en">

7 <head>	7 <head>

8 <title>font-variant-caps test</title>	8 <title>font-variant-caps test</title>

9 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />	9 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

10 <script type="text/javascript" src="resources/gsubtest-features.js"></script>	10 <script type="text/javascript" src="resources/gsubtest-features.js"></script>

11 <script type="text/javascript" src="resources/font-variant-features.js"></script >	11 <script type="text/javascript" src="resources/font-variant-features.js"></script >

12 <link rel="stylesheet" href="resources/font-variant-features.css" type="text/css "/>	12 <link rel="stylesheet" href="resources/font-variant-features.css" type="text/css "/>

13 </head>	13 </head>

14 <body>	14 <body>

15 <div id="content"></div>	15 <div id="content"></div>

16 <script type="text/javascript">	16 <script type="text/javascript">

17 document.getElementById("content").appendChild(createFeatureTestTable(gPropert yData, "font-variant-caps", true, false));	17 document.getElementById("content").appendChild(createFeatureTestTable(gPropert yData, "font-variant-numeric", false, false));

18 </script>	18 </script>
	Timothy Loh 2016/05/11 06:47:25 Can we just testRunner.dumpAsText() to avoid the n Can we just testRunner.dumpAsText() to avoid the need for platform-specific pixel and layout tree expectation? drott 2016/05/11 08:10:46 No, because the PASS, FAIL results are single glyp Show quoted text On 2016/05/11 at 06:47:25, Timothy Loh wrote: > Can we just testRunner.dumpAsText() to avoid the need for platform-specific pixel and layout tree expectation? No, because the PASS, FAIL results are single glyphs, but I forgot that this was meant to be a reftest. Uploaded and added the corresponding expectation.
19 </body>	19 </body>

20 </html>	20 </html>

OLD	NEW