Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1955603003: Bring back sRGB-write-control as a caps bit. (Closed)

Created:
4 years, 7 months ago by Brian Osman
Modified:
4 years, 7 months ago
Reviewers:
bsalomon, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Bring back sRGB-write-control as a caps bit. We're not going to support this on Vulkan (yet), but want to still have it as an option for GL. (The fallback alternative for our YUV use case involves injecting expensive fragment shader code, which we'd like to avoid). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955603003 Committed: https://skia.googlesource.com/skia/+/35b784d48f59be3a3ee28d9d73e03c7f8835d2f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M include/gpu/GrCaps.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/GrCaps.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955603003/1
4 years, 7 months ago (2016-05-05 18:24:45 UTC) #3
Brian Osman
4 years, 7 months ago (2016-05-05 18:24:59 UTC) #5
bsalomon
lgtm
4 years, 7 months ago (2016-05-05 18:47:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955603003/1
4 years, 7 months ago (2016-05-05 18:51:05 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 18:52:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/35b784d48f59be3a3ee28d9d73e03c7f8835d2f9

Powered by Google App Engine
This is Rietveld 408576698