Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1886)

Issue 19556005: Remove dependency from breakpad files on chrome switches. (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Remove dependency from breakpad files on chrome switches. BUG=247431 R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212276

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -41 lines) Patch
M base/base_switches.h View 2 chunks +6 lines, -0 lines 0 comments Download
M base/base_switches.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/app/breakpad_linux.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/app/breakpad_mac.mm View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/breakpad_win.cc View 1 5 chunks +9 lines, -31 lines 0 comments Download
M chrome/app/chrome_breakpad_client.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/app/chrome_breakpad_client.cc View 1 2 3 4 2 chunks +41 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M components/breakpad/breakpad_client.h View 1 2 3 4 2 chunks +9 lines, -1 line 0 comments Download
M components/breakpad/breakpad_client.cc View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jochen (gone - plz use gerrit)
7 years, 5 months ago (2013-07-17 15:18:36 UTC) #1
Mark Mentovai
LGTM
7 years, 5 months ago (2013-07-17 15:21:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/19556005/10001
7 years, 5 months ago (2013-07-17 17:52:07 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/app/breakpad_mac.mm: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-07-17 17:52:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/19556005/3017
7 years, 5 months ago (2013-07-17 19:12:42 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=136683
7 years, 5 months ago (2013-07-18 01:38:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/19556005/3017
7 years, 5 months ago (2013-07-18 05:11:36 UTC) #7
commit-bot: I haz the power
Failed to apply patch for chrome/app/breakpad_linux.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-07-18 05:11:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/19556005/43001
7 years, 5 months ago (2013-07-18 07:11:53 UTC) #9
jochen (gone - plz use gerrit)
7 years, 5 months ago (2013-07-18 08:09:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 manually as r212276 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698