Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: components/breakpad/breakpad_client.h

Issue 19556005: Remove dependency from breakpad files on chrome switches. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | components/breakpad/breakpad_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/breakpad/breakpad_client.h
diff --git a/components/breakpad/breakpad_client.h b/components/breakpad/breakpad_client.h
index 6d4b6caf1a0feb4869670f614114cccff676e768..47e285d61f0b3c516097f6cbf424c26d56dea10e 100644
--- a/components/breakpad/breakpad_client.h
+++ b/components/breakpad/breakpad_client.h
@@ -5,7 +5,8 @@
#ifndef COMPONENTS_BREAKPAD_BREAKPAD_CLIENT_H_
#define COMPONENTS_BREAKPAD_BREAKPAD_CLIENT_H_
-#include "base/basictypes.h"
+#include "base/strings/string16.h"
+#include "build/build_config.h"
namespace base {
class FilePath;
@@ -32,6 +33,13 @@ class BreakpadClient {
// Returns true if an alternative location to store the minidump files was
// specified. Returns true if |crash_dir| was set.
virtual bool GetAlternativeCrashDumpLocation(base::FilePath* crash_dir);
+
+ // Returns a textual description of the product type and version to include
+ // in the crash report.
+ virtual void GetProductNameAndVersion(const base::FilePath& exe_path,
+ base::string16* product_name,
+ base::string16* version,
+ base::string16* special_build);
#endif
// The location where minidump files should be written. Returns true if
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | components/breakpad/breakpad_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698