Issue 1955583002: Second try at fixing location bar icon keyboard activation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1955583002: Second try at fixing location bar icon keyboard activation. (Closed)

Created:
4 years, 7 months ago by Evan Stade

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Second try at fixing location bar icon keyboard activation. Space activates on up, enter activates on down. BUG=608645 Review-Url: https://codereview.chromium.org/1947533003 Cr-Commit-Position: refs/heads/master@{#391451} (cherry picked from commit b98dddabd0ed3058a834d759e067800891c00501) Committed: https://chromium.googlesource.com/chromium/src/+/47e2c11e1f821683bc96acca9fe0f608f8a4aa14

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -10 lines)			Patch
M	chrome/browser/ui/views/location_bar/bubble_icon_view.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/bubble_icon_view.cc	View	1 chunk	+13 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/icon_label_bubble_view.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc	View	1 chunk	+9 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_icon_view.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_icon_view.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

Evan Stade

4 years, 7 months ago (2016-05-05 14:47:04 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
47e2c11e1f821683bc96acca9fe0f608f8a4aa14.