chrome/browser/ui/views/location_bar/icon_label_bubble_view.h - Issue 1955583002: Second try at fixing location bar icon keyboard activation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

Issue 1955583002: Second try at fixing location bar icon keyboard activation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/bubble_icon_view.cc ('k') | chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

diff --git a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

index aac794c3176205481de324efeab2828c96b36b8c..0365292e4c4cc0a5b48198d93ecc89e1f189f91f 100644

--- a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

+++ b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

@@ -85,6 +85,7 @@ class IconLabelBubbleView : public views::InkDropHostView {

// views::View:

gfx::Size GetPreferredSize() const override;

void Layout() override;

+ bool OnKeyPressed(const ui::KeyEvent& event) override;

bool OnKeyReleased(const ui::KeyEvent& event) override;

void OnNativeThemeChanged(const ui::NativeTheme* native_theme) override;

void AddInkDropLayer(ui::Layer* ink_drop_layer) override;