Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 195553002: Consider the origin flag when loading the translate language list (Closed)

Created:
6 years, 9 months ago by Miguel Garcia
Modified:
6 years, 9 months ago
CC:
chromium-reviews, droger
Visibility:
Public.

Description

Consider the origin flag when loading the translate language list BUG=350932 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M components/translate/core/browser/translate_language_list.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_language_list.cc View 4 chunks +9 lines, -3 lines 0 comments Download
M components/translate/core/common/translate_util.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Miguel Garcia
Takashi, do you mind clicking on the commit queue if you are ok with the ...
6 years, 9 months ago (2014-03-11 18:10:22 UTC) #1
Takashi Toyoshima
lgtm
6 years, 9 months ago (2014-03-12 05:27:15 UTC) #2
Takashi Toyoshima
The CQ bit was checked by toyoshim@chromium.org
6 years, 9 months ago (2014-03-12 05:27:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/195553002/1
6 years, 9 months ago (2014-03-12 05:28:21 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 16:40:44 UTC) #5
Message was sent while issue was closed.
Change committed as 256561

Powered by Google App Engine
This is Rietveld 408576698