Fix interstitial ui crashing when open in new tab.

Fix interstitial ui crashing when open in new tab.

BUG=609003
Committed: https://crrev.com/c518abf63a0fdc4b7288f8180997faf0fba0083d
Cr-Commit-Position: refs/heads/master@{#391880}

[Jialiu Lin, 2016-05-04 22:51:17]

jialiul@chromium.org changed reviewers:
+ dpapad@chromium.org

[Jialiu Lin, 2016-05-04 22:51:17]

PTAL
Thanks!

[dpapad, 2016-05-04 23:55:54]

On 2016/05/04 at 22:51:17, jialiul wrote:
> PTAL
> Thanks!

Was the test disabled because of the crash? Can we re-enable now? If not can you
add a comment next to the test with some context (why is it disabled, what needs
to happen to get re-enabled). Perhaps worth linking to a bug.

[Jialiu Lin, 2016-05-05 00:09:15]

On 2016/05/04 at 23:55:54, dpapad wrote:
> On 2016/05/04 at 22:51:17, jialiul wrote:
> > PTAL
> > Thanks!
> 
> Was the test disabled because of the crash? Can we re-enable now? If not can
you add a comment next to the test with some context (why is it disabled, what
needs to happen to get re-enabled). Perhaps worth linking to a bug.

No, the test was disabled long time ago (in 2014?) due to some weird flakiness.
I believe it is a separate problem.

[dpapad, 2016-05-05 00:17:12]

On 2016/05/05 at 00:09:15, jialiul wrote:
> On 2016/05/04 at 23:55:54, dpapad wrote:
> > On 2016/05/04 at 22:51:17, jialiul wrote:
> > > PTAL
> > > Thanks!
> > 
> > Was the test disabled because of the crash? Can we re-enable now? If not can
you add a comment next to the test with some context (why is it disabled, what
needs to happen to get re-enabled). Perhaps worth linking to a bug.
> 
> No, the test was disabled long time ago (in 2014?) due to some weird
flakiness. I believe it is a separate problem.

LGTM

I see. Found https://bugs.chromium.org/p/chromium/issues/detail?id=405869 and
https://bugs.chromium.org/p/chromium/issues/detail?id=400503. As said, perhaps
worth adding a reference to the bug next to the test, not sure if this is a
common practice, but seems like it would save time for the future reader.

[Jialiu Lin, 2016-05-05 00:23:07]

On 2016/05/05 at 00:17:12, dpapad wrote:
> On 2016/05/05 at 00:09:15, jialiul wrote:
> > On 2016/05/04 at 23:55:54, dpapad wrote:
> > > On 2016/05/04 at 22:51:17, jialiul wrote:
> > > > PTAL
> > > > Thanks!
> > > 
> > > Was the test disabled because of the crash? Can we re-enable now? If not
can you add a comment next to the test with some context (why is it disabled,
what needs to happen to get re-enabled). Perhaps worth linking to a bug.
> > 
> > No, the test was disabled long time ago (in 2014?) due to some weird
flakiness. I believe it is a separate problem.
> 
> LGTM
> 
> I see. Found https://bugs.chromium.org/p/chromium/issues/detail?id=405869 and
https://bugs.chromium.org/p/chromium/issues/detail?id=400503. As said, perhaps
worth adding a reference to the bug next to the test, not sure if this is a
common practice, but seems like it would save time for the future reader.

Sure, bug reference added. Thanks!

[Jialiu Lin, 2016-05-05 18:09:30]

The CQ bit was checked by jialiul@chromium.org

[Jialiu Lin, 2016-05-05 18:09:30]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/1955443002/#ps40001
(title: "link to bug")

[commit-bot: I haz the power, 2016-05-05 18:10:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955443002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955443002/40001

[commit-bot: I haz the power, 2016-05-05 19:56:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-05 19:57:51]

Description was changed from

==========
Fix interstitial ui crashing when open in new tab.

BUG=609003
==========

to

==========
Fix interstitial ui crashing when open in new tab.

BUG=609003

Committed: https://crrev.com/c518abf63a0fdc4b7288f8180997faf0fba0083d
Cr-Commit-Position: refs/heads/master@{#391880}
==========

[commit-bot: I haz the power, 2016-05-05 19:57:52]

Patchset 3 (id:??) landed as
https://crrev.com/c518abf63a0fdc4b7288f8180997faf0fba0083d
Cr-Commit-Position: refs/heads/master@{#391880}