chrome/browser/ui/webui/interstitials/interstitial_ui.cc - Issue 1955443002: Fix interstitial ui crashing when open in new tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/interstitials/interstitial_ui.cc

Issue 1955443002: Fix interstitial ui crashing when open in new tab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: link to bug Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/interstitials/interstitial_ui.cc

diff --git a/chrome/browser/ui/webui/interstitials/interstitial_ui.cc b/chrome/browser/ui/webui/interstitials/interstitial_ui.cc

index f228c518f0f3e3eea8a65bbb1221306316899422..a0dc29837e5bfbd696dafa92451f64dcefaea952 100644

--- a/chrome/browser/ui/webui/interstitials/interstitial_ui.cc

+++ b/chrome/browser/ui/webui/interstitials/interstitial_ui.cc

@@ -218,7 +218,7 @@ safe_browsing::SafeBrowsingBlockingPage* CreateSafeBrowsingBlockingPage(

resource.threat_type = threat_type;

resource.render_process_host_id =

web_contents->GetRenderProcessHost()->GetID();

- resource.render_frame_id = web_contents->GetFocusedFrame()->GetRoutingID();

+ resource.render_frame_id = web_contents->GetMainFrame()->GetRoutingID();

resource.threat_source = safe_browsing::ThreatSource::LOCAL_PVER3;

// Normally safebrowsing interstitial types which block the main page load

« no previous file with comments | « no previous file | chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc » ('j') | no next file with comments »