Add flexible keybinding/command system to sk_app

Add flexible keybinding/command system to sk_app.

Viewer demonstrates use: Just create an instance of CommandSet,
register with the window, and add commands. Hopefully, we can keep
all commands in one place, and get some nice side-benefits. With
this framework, if you want to add a new command, you are only
required to add code in ONE place. And you get added to the help
screen, for free.

CommandSet automatically binds 'h' to cycle through the help modes.
(Functional grouping is most useful for general use, but the other
mode is nice to know what a key does, or to find an unused key for
a new feature).

Grouped by function: https://screenshot.googleplex.com/G5h3f52wFKu.png
Alphabetical by key: https://screenshot.googleplex.com/nZiopabLKJ6.png

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955293002

Committed: https://skia.googlesource.com/skia/+/622c8d5de12f264e496e8d4664a2eea9333922d0

[Brian Osman, 2016-05-08 16:01:52]

Description was changed from

==========
Add flexible keybinding/command system to Viewer.

Hopefully, we can keep all commands in one place, and get some nice
side-benefits. With this framework, if you want to add a new command,
you are only required to add code in ONE place. And you get added to
the help screen, for free.

Screenshot: https://screenshot.googleplex.com/1PWzJfAhDgE.png

BUG=skia:
==========

to

==========
Add flexible keybinding/command system to Viewer.

Hopefully, we can keep all commands in one place, and get some nice
side-benefits. With this framework, if you want to add a new command,
you are only required to add code in ONE place. And you get added to
the help screen, for free.

Screenshot: https://screenshot.googleplex.com/1PWzJfAhDgE.png

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Brian Osman, 2016-05-08 16:15:43]

Description was changed from

==========
Add flexible keybinding/command system to Viewer.

Hopefully, we can keep all commands in one place, and get some nice
side-benefits. With this framework, if you want to add a new command,
you are only required to add code in ONE place. And you get added to
the help screen, for free.

Screenshot: https://screenshot.googleplex.com/1PWzJfAhDgE.png

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add flexible keybinding/command system to Viewer.

Hopefully, we can keep all commands in one place, and get some nice
side-benefits. With this framework, if you want to add a new command,
you are only required to add code in ONE place. And you get added to
the help screen, for free.

Screenshot: https://screenshot.googleplex.com/sCTqL55J1Vz.png

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Brian Osman, 2016-05-08 16:22:15]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, jvanverth@google.com

[Brian Osman, 2016-05-08 16:22:49]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-08 16:22:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955293002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955293002/1

[commit-bot: I haz the power, 2016-05-08 16:48:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-08 16:48:44]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-05-09 13:20:58]

This looks super handy. Should we factor it out as a helper in sk_app that is
used by viewer?

[jvanverth1, 2016-05-09 13:33:31]

On 2016/05/09 13:20:58, bsalomon wrote:
> This looks super handy. Should we factor it out as a helper in sk_app that is
> used by viewer?

+1

[Brian Osman, 2016-05-09 16:21:24]

On 2016/05/09 13:33:31, jvanverth1 wrote:
> On 2016/05/09 13:20:58, bsalomon wrote:
> > This looks super handy. Should we factor it out as a helper in sk_app that
is
> > used by viewer?
> 
> +1

Yes, that sounds good. I think turning it into a CommandSet object that can be
dropped into Viewer, with addCommand(...) and installHandlers(Window*) will do
the trick.

[Brian Osman, 2016-05-09 19:47:34]

Description was changed from

==========
Add flexible keybinding/command system to Viewer.

Hopefully, we can keep all commands in one place, and get some nice
side-benefits. With this framework, if you want to add a new command,
you are only required to add code in ONE place. And you get added to
the help screen, for free.

Screenshot: https://screenshot.googleplex.com/sCTqL55J1Vz.png

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add flexible keybinding/command system to sk_app.

Viewer demonstrates use: Just create an instance of CommandSet,
register with the window, and add commands. Hopefully, we can keep
all commands in one place, and get some nice side-benefits. With
this framework, if you want to add a new command, you are only
required to add code in ONE place. And you get added to the help
screen, for free.

CommandSet automatically binds 'h' to cycle through the help modes.
(Functional grouping is most useful for general use, but the other
mode is nice to know what a key does, or to find an unused key for
a new feature).

Grouped by function: https://screenshot.googleplex.com/G5h3f52wFKu.png
Alphabetical by key: https://screenshot.googleplex.com/nZiopabLKJ6.png

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Brian Osman, 2016-05-09 19:48:31]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 19:48:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955293002/20001

[Brian Osman, 2016-05-09 19:48:53]

Better.

[commit-bot: I haz the power, 2016-05-09 20:10:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 20:10:45]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-05-09 20:25:53]

lgtm with some minor comments inline

https://codereview.chromium.org/1955293002/diff/20001/tools/viewer/sk_app/Com...
File tools/viewer/sk_app/CommandSet.h (right):

https://codereview.chromium.org/1955293002/diff/20001/tools/viewer/sk_app/Com...
tools/viewer/sk_app/CommandSet.h:20: class CommandSet {
Maybe a little bit of comment text to explain what this is for?

https://codereview.chromium.org/1955293002/diff/20001/tools/viewer/sk_app/Win...
File tools/viewer/sk_app/Window.h (right):

https://codereview.chromium.org/1955293002/diff/20001/tools/viewer/sk_app/Win...
tools/viewer/sk_app/Window.h:44: enum class Key {
When we use enum class we drop the _<Type> suffix

[Brian Osman, 2016-05-09 20:47:00]

Addressed review issues.

[Brian Osman, 2016-05-09 21:04:36]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 21:04:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955293002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955293002/40001

[commit-bot: I haz the power, 2016-05-09 21:06:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 21:06:15]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[Brian Osman, 2016-05-09 21:16:26]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 21:16:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955293002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955293002/60001

[commit-bot: I haz the power, 2016-05-09 21:38:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 21:38:08]

Dry run: This issue passed the CQ dry run.

[jvanverth1, 2016-05-10 12:55:49]

If you're waiting on me, lgtm

[Brian Osman, 2016-05-10 13:49:50]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-05-10 13:49:51]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1955293002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-05-10 13:49:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955293002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955293002/60001

[commit-bot: I haz the power, 2016-05-10 13:50:51]

Description was changed from

==========
Add flexible keybinding/command system to sk_app.

Viewer demonstrates use: Just create an instance of CommandSet,
register with the window, and add commands. Hopefully, we can keep
all commands in one place, and get some nice side-benefits. With
this framework, if you want to add a new command, you are only
required to add code in ONE place. And you get added to the help
screen, for free.

CommandSet automatically binds 'h' to cycle through the help modes.
(Functional grouping is most useful for general use, but the other
mode is nice to know what a key does, or to find an unused key for
a new feature).

Grouped by function: https://screenshot.googleplex.com/G5h3f52wFKu.png
Alphabetical by key: https://screenshot.googleplex.com/nZiopabLKJ6.png

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add flexible keybinding/command system to sk_app.

Viewer demonstrates use: Just create an instance of CommandSet,
register with the window, and add commands. Hopefully, we can keep
all commands in one place, and get some nice side-benefits. With
this framework, if you want to add a new command, you are only
required to add code in ONE place. And you get added to the help
screen, for free.

CommandSet automatically binds 'h' to cycle through the help modes.
(Functional grouping is most useful for general use, but the other
mode is nice to know what a key does, or to find an unused key for
a new feature).

Grouped by function: https://screenshot.googleplex.com/G5h3f52wFKu.png
Alphabetical by key: https://screenshot.googleplex.com/nZiopabLKJ6.png

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/622c8d5de12f264e496e8d4664a2eea9333922d0
==========

[commit-bot: I haz the power, 2016-05-10 13:50:52]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/622c8d5de12f264e496e8d4664a2eea9333922d0