Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 19552003: Remove unnecessary conditional check while deciding for XML viewer mode. (Closed)

Created:
7 years, 5 months ago by vivekg_samsung
Modified:
7 years, 5 months ago
Reviewers:
pdr., eseidel, vivekg__
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove unnecessary conditional check while deciding for XML viewer mode. R=eseidel, pdr Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
vivekg__
7 years, 5 months ago (2013-07-17 09:08:43 UTC) #1
eseidel
Does this actually come up for the XML Viewer mode? Does this change behavior?
7 years, 5 months ago (2013-07-17 16:43:28 UTC) #2
pdr.
Please include a better change description :) What prompted this change?
7 years, 5 months ago (2013-07-17 20:12:24 UTC) #3
vivekg_samsung
@pdr, I was debugging an issue for RSS feeds and came across this piece of ...
7 years, 5 months ago (2013-07-18 01:18:59 UTC) #4
pdr.
On 2013/07/18 01:18:59, vivekg wrote: > @pdr, I was debugging an issue for RSS feeds ...
7 years, 5 months ago (2013-07-18 01:24:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/19552003/1
7 years, 5 months ago (2013-07-18 01:57:35 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-18 02:20:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/19552003/1
7 years, 5 months ago (2013-07-18 02:21:42 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-18 02:33:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/19552003/1
7 years, 5 months ago (2013-07-20 01:46:37 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=246
7 years, 5 months ago (2013-07-20 02:08:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/19552003/1
7 years, 5 months ago (2013-07-21 03:27:37 UTC) #12
commit-bot: I haz the power
7 years, 5 months ago (2013-07-21 04:54:06 UTC) #13
Message was sent while issue was closed.
Change committed as 154606

Powered by Google App Engine
This is Rietveld 408576698