Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 1955183002: Revert of DevTools: account for the display scale factor while validating manifest under emulation. (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
dominickn, gone, pfeldman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: account for the display scale factor while validating manifest under emulation. (patchset #5 id:80001 of https://codereview.chromium.org/1950133009/ ) Reason for revert: For reasons outlined in latest comment. Original issue's description: > DevTools: account for the display scale factor while validating manifest under emulation. > > BUG=609580 > TBR=sky > > Committed: https://crrev.com/aeb778c817766d5c3b17097556218b0bafdbd1d4 > Cr-Commit-Position: refs/heads/master@{#392171} TBR=dominickn@chromium.org,dfalcantara@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=609580 Committed: https://crrev.com/23ac1ebc5f3a65cc260e6d4e83015d04ff7a3441 Cr-Commit-Position: refs/heads/master@{#392204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -89 lines) Patch
D chrome/browser/banners/app_banner_manager_emulation.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/banners/app_banner_manager_emulation.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M chrome/browser/chrome_service_worker_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +18 lines, -6 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sky
Created Revert of DevTools: account for the display scale factor while validating manifest under emulation.
4 years, 7 months ago (2016-05-06 23:38:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955183002/1
4 years, 7 months ago (2016-05-06 23:38:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 23:39:18 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 23:40:47 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23ac1ebc5f3a65cc260e6d4e83015d04ff7a3441
Cr-Commit-Position: refs/heads/master@{#392204}

Powered by Google App Engine
This is Rietveld 408576698