chrome/browser/chrome_service_worker_browsertest.cc - Issue 1955183002: Revert of DevTools: account for the display scale factor while validating manifest under emulation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_service_worker_browsertest.cc

Issue 1955183002: Revert of DevTools: account for the display scale factor while validating manifest under emulation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chrome_service_worker_browsertest.cc

diff --git a/chrome/browser/chrome_service_worker_browsertest.cc b/chrome/browser/chrome_service_worker_browsertest.cc

index 8d054fc64659d88a29cd2d5840b2fade6b70de58..fca044785b2b6e7a4eedfdcf662840e23eea01f2 100644

--- a/chrome/browser/chrome_service_worker_browsertest.cc

+++ b/chrome/browser/chrome_service_worker_browsertest.cc

@@ -273,8 +273,8 @@

}

std::string RequestAppBannerAndGetIssuedRequests() {

- browser()->RequestAppBannerFromDevTools(

- browser()->tab_strip_model()->GetActiveWebContents());

+ EXPECT_TRUE(browser()->RequestAppBanner(

+ browser()->tab_strip_model()->GetActiveWebContents()));

return ExecuteScriptAndExtractString(

"if (issuedRequests.length != 0) reportRequests();"

"else reportOnFetch = true;");

« no previous file with comments | « chrome/browser/banners/app_banner_manager_emulation.cc ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »